Skip to content

Fix Explorer selection, dragging, rename and clipboard actions - #31

Merged
JamieW105 merged 5 commits into
mainfrom
fix/explorer-interactions
Oct 13, 2026
Merged

JamieW105 merged 5 commits into
mainfrom
fix/explorer-interactions

Conversation

@JamieW105

@JamieW105 JamieW105 commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Explorer now highlights files/folders on a single click and renames them on a double click. Pressing an unhighlighted item only highlights it; dragging requires a new primary-button press on an already highlighted item and moves the highlighted group. Shift-click/hold adds items; Ctrl-click selects the visible range from the last highlighted item. These revised gestures apply only to Explorer; Scene controls retain their behavior.

Ctrl+C copies the highlighted group. Ctrl+V pastes every copied entry into every selected destination folder, including nested selected destinations; without a selected folder it uses the last selected file's parent or project root. Text editing keeps normal clipboard shortcuts. Grouped Copy/Cut/Delete is also available through right-click/two-finger menus, and file Open moves to that menu. Rename preserves selection; batches refresh completed operations and report individual errors. Cut accepts one destination; use Copy for fan-out paste.

The PR also retains the branch’s model-refresh and destination-collision fixes, fixes expanded-folder drag interference, adds scene object clipboard/delete controls with Undo/Redo, script scope menus, and World/Local gizmo choices. File deletion is recoverable in .rustic/trash; file moves/renames retain sidecar metadata. Manifest and companion references still require manual updates. Grouped viewport drops are limited to one model/script at a time.

Validation:

  • Full Linux and Windows CI passed, including rendering and headless smoke checks, adapter conformance, security and the fresh Windows installer: https://github.com/Rustic-Game-Engine/engine/actions/runs/38309024462.
  • cargo test --locked -p rustic-editor -p engine-editor: 49 tests pass.
  • Strict Clippy across both packages/all targets, Cargo formatting and editor headless smoke pass.
  • UI tests cover press-time drag eligibility, highlighted group dragging, Ctrl range selection, Shift-held selection, Ctrl+C/V fan-out/repeated paste, inline rename commit/cancel, context menus and empty-space root controls.
  • Filesystem tests cover metadata, collisions, traversal, symlinks, recoverable deletion and partial paste failures.
  • Fresh Windows installer build passed for commit 7b36f526: RusticGameEngine-Setup-0.1.0-x64-20261012-212222.exe. Downloaded and verified the executable. Installer artifact.
  • Full Linux CI passed. The broader Windows engine test job is still running.

Companion docs: Rustic-Game-Engine/docs#37 (lint, types, production build, docs/link checks and dependency audit pass). Original documentation: Rustic-Game-Engine/docs#35.

@JamieW105

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T20:55:48.557781Z 9435604 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JamieW105 JamieW105 self-assigned this Oct 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9435604f4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Engine/apps/editor/src/main.rs Outdated
Comment thread Engine/apps/editor/src/main.rs Outdated
Comment thread Engine/apps/editor/src/main.rs Outdated
Comment thread Engine/apps/editor/src/main.rs
@JamieW105 JamieW105 changed the title Fix Explorer dragging, renaming and right-click actions Fix Explorer selection, dragging, rename and clipboard actions Oct 12, 2026
@JamieW105
JamieW105 merged commit 6bd9892 into main Oct 13, 2026
8 checks passed
@github-actions
github-actions Bot deleted the fix/explorer-interactions branch October 13, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants