Repository navigation
Stop repeated installer toolchain startup failures - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all optional languages selected, Setup can launch PowerShell up to 15 times for repeated checks and per-language installs. Run all selections in one hidden, noninteractive process as the original user. Stop the batch if WinGet returns 142 or 0xc0000142, skip installed tools, and keep ordinary package failures aggregated.
Record host launch errors and exit codes in an automatic Setup log, resolve the toolchain transcript in the original user's profile, and write a clear package-and-code line for each failed install. Show one optional-toolchain failure while leaving Rustic installed. Validate Inno syntax and Windows PowerShell regression cases before the expensive engine build.
Validation: fresh Windows installer build passed, producing
RusticGameEngine-Setup-0.1.0-x64-20261013-212947.exe. All 12 Windows PowerShell regression scenarios and four silent packaged Setup scenarios passed, including all selected languages sharing one host, stopping on initialization failure, keeping the engine installed, and bundled-only Setup skipping the manager. The engine CI jobs on Windows and Linux, language adapter conformance, workflow syntax, secret scan, and Rust dependency audit passed. Local manager smoke checks and all nine installer-release tests also passed.Tested installer artifact: https://github.com/Rustic-Game-Engine/engine/actions/runs/38469014259/artifacts/11850569802
Build and test logs: https://github.com/Rustic-Game-Engine/engine/actions/runs/38469014259
The original reported error was not reproducible; this change removes repeated host launches and improves diagnosis without claiming a confirmed root cause.
Companion documentation PR: Rustic-Game-Engine/docs#38 (lint, production build, TypeScript, dependency audit, and exported links passed).