Repository navigation
Fix WASD and Q/E navigation after focusing the 3D viewport - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the 3D viewport previously gave it keyboard focus and then disabled WASD and Q/E: egui reports keyboard capture for any focused widget, including the viewport itself. Allow the focused viewport to receive its own keys, retain hover navigation when no other widget has focus, and pause keyboard navigation when the editor window loses focus. Use the same focus rule for embedded Play input.
Add headless egui regression tests for clicked/hovered viewports, text-field focus and window focus loss. Document controls and recovery steps in the engine guide and the companion website PR: Rustic-Game-Engine/docs#39.
Validation:
rustic-editortests passed, including the three focus regression tests.cargo fmt --all -- --checkandgit diff --checkpassed.cargo clippy --locked -p rustic-editor --all-targets -- -D warningspassed.windows-installerartifact: https://github.com/Rustic-Game-Engine/engine/actions/runs/38491493926/artifacts/11862971142.Native desktop interaction has not been manually tested in this workspace.