Add MCP server agent evals; require SCAPI/CIP skill reads - #730
Merged
Merged
Conversation
- packages/b2c-dx-mcp/evals: claude plugin eval suite (compliance by default, ablation-tagged enhancement cases with Δ) - skillRead is a required literal on scapi_search, scapi_execute and cip_query; slimmer SCAPI descriptions with code-mode details moved into the SCAPI skill - Point first-deploy questions to the config skill - SCAPI code mode accepts trailing semicolons and line comments
clavery
requested review from
patricksullivansf,
wei-liu-sf and
yhsieh1
as code owners
October 1, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds agent-level evals for the MCP server and the tool/guidance fixes they surfaced.
Evals (
packages/b2c-dx-mcp/evals) — aclaude plugin evalsuite that runs the locally built server:pnpm run mcp:eval): every case, plugin loaded,--ablation none. Checks tool choice, required skill reads, tools that must not be called, and no terminal fallback.pnpm run mcp:eval:ablation):ablation-tagged docs cases run with and without the plugin and report Δ. Path graders arearm: with-onlyso the no-plugin arm is judged on its answer.dw.json.docs_schema_readis flagged (whole-XSD output is too large) and its case is indisabled/.MCP fixes
skillReadis now a requiredtrueliteral onscapi_search,scapi_executeandcip_query. Before, only Opus 5.5 read the SCAPI skill first; Sonnet 5/5.5 now do too.scapi_executeis described as the general path for Admin/Shopper tasks when no dedicated tool fits.cartridge_deploypoint first-deploy prerequisite questions to the config skill.SDK fix
Latest results (Sonnet 5.5): compliance cases 1.00; enhancement mean Δ +0.61.
Testing
Requires the
claudeCLI withplugin eval.pnpm --filter @salesforce/b2c-tooling-sdk run build && pnpm --filter @salesforce/b2c-dx-mcp run buildpnpm run mcp:eval --runs 1 -j 5— compliance cases should pass.pnpm run mcp:eval:ablation --runs 1 -j 5— each case should show a positive Δ.skill://mcp/scapi/SKILL.mdbeforescapi_search.