Repository navigation
test(web): timeline expansion test waits for the list to settle - #58
Merged
Merged
Conversation
Wait for LegendList to finish its hidden initial layout before recording the heading position. Keep real timers running through the click and expansion so the virtualizer can complete its layout work. Co-Authored-By: GPT-6 Astra <noreply@openai.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessagesTimeline's "keeps the worked-for heading in place when expanded at the bottom" failed onmainoften enough to reddenClient and package tests, and therefore the required Fork Check, on every PR.It was a test bug. The test measured the heading during LegendList's hidden first layout:
toBeVisible()ignores opacity, so the heading could still move from 473 to 577 before the click handler ran, then stayed at 577 after expansion. Fake timers installed before the click also stalled the list, which showed up on CI aslegend-list-content-container intercepts pointer events.The test now waits for opacity-aware visibility and the bottom position, and leaves real timers running. Product code and the strict position assertions are unchanged.
Before: 3 of 3 full-file runs failed. After: 10 consecutive full-file runs passed, 40 tests each.
vp run check:changed origin/mainpasses.GPT-6 Astra via Codex in T3 Code; PR opened by Claude Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code