Skip to content

test(web): timeline expansion test waits for the list to settle #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Nov 4, 2026
Merged

test(web): timeline expansion test waits for the list to settle #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,15 +238,15 @@ describe("MessagesTimeline work rows", () => {
const heading = screen.getByRole("button", { name: /^Worked for/ });
await expect.element(heading).toBeVisible();
const viewport = props.listRef.current!.getScrollableNode()!;
await vi.waitFor(() =>
expect(viewport.scrollHeight - viewport.clientHeight - viewport.scrollTop).toBeLessThan(2),
);
await vi.waitFor(() => {
// LegendList hides its initial layout with opacity, which toBeVisible does not check.
expect(heading.element().checkVisibility({ checkOpacity: true })).toBe(true);
expect(viewport.scrollHeight - viewport.clientHeight - viewport.scrollTop).toBeLessThan(2);
});
expect(viewport.scrollTop).toBeGreaterThan(0);
const top = heading.element().getBoundingClientRect().top;
const height = viewport.scrollHeight;
using _timers = fakeTimers();
await heading.click();
await act(() => vi.advanceTimersByTime(1000));
await vi.waitFor(() => {
expect(viewport.scrollHeight).toBeGreaterThan(height + 500);
expect(heading.element().getBoundingClientRect().top).toBeCloseTo(top, 0);
Expand Down
Loading