[VietND96]

Summary

Follow-up to #3167. kedacore/keda#8107 (merged, shipped in KEDA 2.21.0) added includeOngoingSessions to the built-in selenium-grid scaler - the exact same trigger param, default (true), and metric/activation-threshold calculation this chart's _helpers.tpl and this project's external scaler have already carried since fixing #3167.

Below KEDA 2.21.0, the built-in scaler simply doesn't recognize includeOngoingSessions and ignores it. So a user on this chart's default scalingStrategy.strategy: accurate + the built-in scaler (autoscaling.externalScaler.enabled: false) still hits the runaway Job creation #3167 describes on any KEDA older than 2.21.0 - even though the chart has been correctly setting includeOngoingSessions: "false" in the trigger metadata in that combination all along; the built-in scaler just wasn't listening yet.

What this does

• Bumps the chart's own keda subchart dependency floor from ^2.20.0 to ^2.21.0, so a chart-bundled KEDA install (autoscaling.enabled without enableWithExistingKEDA) always gets a KEDA that honors the fix.
• Documents the one case the dependency bump can't reach: autoscaling.enableWithExistingKEDA brings the user's own KEDA installation, whose version this chart has no control over. Calls out the >=2.21.0 requirement explicitly for that combination with the built-in scaler.
• Fixes an adjacent stale README claim that the built-in scaler is still the default - it's been externalScaler.enabled: true for a while now, and the external scaler isn't affected by any of this since it's never relied on KEDA's own scaler code.

The external scaler itself needs no change. I compared it line by line against the upstream KEDA diff: same trigger metadata key (includeOngoingSessions), same default (true), and the same metric/activation-threshold calculation (.keda-external-scaler/internal/gridscaler/server.go:97-113 vs. the upstream pkg/scalers/selenium_grid_scaler.go change) - it was already exactly aligned, which makes sense since it's the same author's fix landed in both places.

Test plan

• helm dependency update charts/selenium-grid now locks keda to 2.21.0 (was 2.20.2).
• helm lint charts/selenium-grid passes.
• helm template ... --set autoscaling.enabled=true --set autoscaling.scalingType=job --set autoscaling.externalScaler.enabled=false still renders type: selenium-grid with includeOngoingSessions: "false" on the built-in-scaler trigger, matching the chart's default accurate strategy.
• make lint_format_scripts (helm-docs) regenerated CONFIGURATION.md's dependency table and version badge consistently with the Chart.yaml changes.

🤖 Generated with Claude Code

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing