Skip to content

[chart] Require KEDA >=2.21.0 so the built-in scaler honors includeOngoingSessions #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VietND96 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[chart] Require KEDA >=2.21.0 so the built-in scaler honors includeOngoingSessions #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/selenium-grid/CONFIGURATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# selenium-grid

![Version: 0.62.0](https://img.shields.io/badge/Version-0.62.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.51.0-20261010](https://img.shields.io/badge/AppVersion-4.51.0--20261010-informational?style=flat-square)
![Version: 0.62.2](https://img.shields.io/badge/Version-0.62.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.51.0-20261010](https://img.shields.io/badge/AppVersion-4.51.0--20261010-informational?style=flat-square)

A Helm chart for creating a Selenium Grid Server in Kubernetes

Expand All @@ -21,7 +21,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
| https://cloudpirates-io.github.io/helm-charts | postgresql(postgres) | ^0.21.0 |
| https://cloudpirates-io.github.io/helm-charts | redis | ^0.37.0 |
| https://jaegertracing.github.io/helm-charts | jaeger | ^4.0.0 |
| https://kedacore.github.io/charts | keda | ^2.20.0 |
| https://kedacore.github.io/charts | keda | ^2.21.0 |
| https://prometheus-community.github.io/helm-charts | kube-prometheus-stack | ^92.0.0 |
| https://traefik.github.io/charts | traefik | ^42.0.0 |

Expand Down
11 changes: 9 additions & 2 deletions charts/selenium-grid/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,19 @@ apiVersion: v2
name: selenium-grid
description: A Helm chart for creating a Selenium Grid Server in Kubernetes
type: application
version: 0.62.1
version: 0.62.2
appVersion: 4.51.0-20261010
icon: https://github.com/SeleniumHQ/docker-selenium/raw/trunk/logo.png
dependencies:
- repository: https://kedacore.github.io/charts
version: ^2.20.0
# 2.21.0 is the first release carrying the built-in selenium-grid scaler's
# includeOngoingSessions trigger param (kedacore/keda#8107); below that, the
# scalingStrategy.strategy=accurate/eager default this chart ships causes
# the runaway Job creation in #3167 whenever the built-in scaler
# (autoscaling.externalScaler.enabled=false) is used instead of this
# project's external scaler, which has carried the fix on its own since
# before this param existed upstream, regardless of the KEDA version.
version: ^2.21.0
name: keda
condition: autoscaling.enabled, keda.enabled
- repository: https://traefik.github.io/charts
Expand Down
27 changes: 21 additions & 6 deletions charts/selenium-grid/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,18 @@ To do this [KEDA](https://keda.sh/docs/latest/scalers/selenium-grid-scaler/) is
autoscaling using `autoscaling.enabling` KEDA is installed automatically. To instead use an existing
installation of KEDA you can enable autoscaling with `autoscaling.enableWithExistingKEDA` instead.

**With an existing KEDA installation and the built-in `selenium-grid` scaler**
(`autoscaling.externalScaler.enabled: false`), make sure it's **KEDA ≥ 2.21.0**.
This chart's default `scalingType: job` strategy (`accurate`) relies on the
built-in scaler honouring the `includeOngoingSessions` trigger parameter this
chart sets automatically; older KEDA versions silently ignore it and hit the
runaway Job creation in
[#3167](https://github.com/SeleniumHQ/docker-selenium/issues/3167). The chart's
own bundled KEDA subchart dependency already requires `^2.21.0` for this
reason; this only matters when bringing your own installation. The default
[external scaler](#use-the-standalone-selenium-grid-external-scaler) isn't
affected by the KEDA version at all, since it carries this fix itself.

KEDA can scale either with
[deployments](https://keda.sh/docs/latest/concepts/scaling-deployments/#scaling-of-deployments-and-statefulsets)
or [jobs](https://keda.sh/docs/latest/concepts/scaling-jobs/) and the charts support both types. This
Expand All @@ -154,13 +166,16 @@ Refer to [README](../../.keda/README.md)

### Use the standalone Selenium Grid external scaler

By default the chart uses KEDA's built-in `selenium-grid` scaler, which is released
on KEDA's cadence. The chart can instead deploy the standalone
[Selenium Grid KEDA external scaler](../../.keda-external-scaler/README.md), a gRPC
scaler owned by this project, so scaling fixes ship with docker-selenium releases.
Scaling behaviour is identical; only the trigger wiring changes.
By default (`autoscaling.externalScaler.enabled: true`) the chart deploys the
standalone [Selenium Grid KEDA external scaler](../../.keda-external-scaler/README.md),
a gRPC scaler owned by this project, so scaling fixes ship with docker-selenium
releases instead of waiting on KEDA's own release cadence. Set
`autoscaling.externalScaler.enabled: false` to use KEDA's built-in
`selenium-grid` scaler instead - scaling behaviour is identical; only the
trigger wiring changes.

Enable it with:
The external scaler is already enabled by default; the example below is for
reference, or to re-enable it after having set it to `false`:

```yaml
autoscaling:
Expand Down
Loading