Repository navigation
Conversation
Ankit-cs
requested review from
Akshat0694,
arunim2405 and
refeed
as code owners
October 15, 2026 15:11
Author
|
looking for feedback for the above pr |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Author
|
Please look my pr for the above issue @refeed , @Akshat0694 , @arunim2405 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #404
Pull Request Template
Description
What changes are being made?
src/tirith/providers/kubernetes/handler.py, appended the error results for missingkubernetes_kindand missingattribute_pathtooutputsbefore returning.tests/providers/kubernetes/test_missing_arguments.pytesting both missing argument scenarios.Why are these changes necessary?
get_valuereturned the error dictionary directly without appending it tooutputs. Becauseprovide()ignores the return value and returnsoutputs, missing argument errors were silently dropped as[].Which issues or tickets does this PR close or relate to?
kubernetes_kindorattribute_patherrors are dropped #404kubernetes_kindorattribute_patherrors are dropped #404Type of Change
Checklist
Additional Information
provide()withoutkubernetes_kindand withoutattribute_path, verifying that the matching error message is returned in each case.origin/main.