Skip to content

fix(kubernetes): missing kubernetes_kind or attribute_path errors are dropped #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ankit-cs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kubernetes): missing kubernetes_kind or attribute_path errors are dropped #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/tirith/providers/kubernetes/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,15 @@ def get_value(provider_args: Dict, input_data: Union[Dict, List], outputs: list)
attribute_path: str = provider_args.get("attribute_path", "")

if target_kind is None:
return create_result_dict(value=ProviderError(severity_value=99), err="kubernetes_kind must be provided")
outputs.append(
create_result_dict(value=ProviderError(severity_value=99), err="kubernetes_kind must be provided")
)
return outputs
if attribute_path == "":
return create_result_dict(value=ProviderError(severity_value=99), err="attribute_path must be provided")
outputs.append(
create_result_dict(value=ProviderError(severity_value=99), err="attribute_path must be provided")
)
return outputs

kubernetes_resources = input_data
is_kind_found = False
Expand Down
15 changes: 15 additions & 0 deletions tests/providers/kubernetes/test_missing_arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from tirith.providers.kubernetes.handler import provide


def test_missing_kubernetes_kind():
result = provide({"operation_type": "attribute", "attribute_path": "spec"}, [{"kind": "Pod", "spec": {}}])
assert len(result) == 1
assert result[0]["err"] == "kubernetes_kind must be provided"
assert result[0]["value"].severity_value == 99


def test_missing_attribute_path():
result = provide({"operation_type": "attribute", "kubernetes_kind": "Pod"}, [{"kind": "Pod", "spec": {}}])
assert len(result) == 1
assert result[0]["err"] == "attribute_path must be provided"
assert result[0]["value"].severity_value == 99
Loading