Repository navigation
Add build support for .NET 11 SDK and run all tests against .NET 11 - #1777
bart-vmware wants to merge 3 commits into
Conversation
|
Azure Pipelines: 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
97771d9 to
670d9ce
Compare
Summary - All Code Coverage (ubuntu-latest)
|
670d9ce to
c546aea
Compare
c546aea to
68d4976
Compare
|
| uses: actions/setup-dotnet@v6 | ||
| with: | ||
| dotnet-version: 10.0.* | ||
| dotnet-version: 11.0.* |
There was a problem hiding this comment.
Do you have any concern about the sign tool working with the net11 sdk? I suppose we can address it if it fails, but I don't think we'll hit this path until the pr merges
| internal sealed class CertificateCollector : IDisposable | ||
| { | ||
| #pragma warning disable IDE0028 // Simplify collection initialization | ||
| // Justification: workaround for bug https://youtrack.jetbrains.com/issue/RSRP-505438/Collection-expression-with-with-expression-requires-language-version-preview |
There was a problem hiding this comment.
If I'm reading the youtrack issues correctly, your report was classified as a dupe of an issue that was fixed in 2026.3, which this PR bumps us to... Any chance this suppression isn't actually needed?
There was a problem hiding this comment.
Nevermind, it's fixed in the NEXT 2026.3 release
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Is the removal of this newline intentional?
| [ | ||
| "Microting.EntityFrameworkCore.MySql", | ||
| "MySqlConnector", | ||
| // Temporary workaround: The assembly name changed in the stable 10.x version, but the 11.0.0-preview.1 version doesn't contain that change yet. |
There was a problem hiding this comment.
Do we need a tracking issue for dealing with this pre-release package ref & workaround? I'm assuming you wouldn't intend to ship with it and see that they plan to release in the next 7-10 days
| </None> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net10.0' Or '$(TargetFramework)' == 'net9.0' or '$(TargetFramework)' == 'net8.0'"> |
There was a problem hiding this comment.
Nit: this line uses both Or and or
| var hashcodeBuilder = new StringBuilder(); | ||
|
|
||
| foreach (KeyValuePair<string, int> pair in statusMap.OrderBy(pair => pair.Key)) | ||
| foreach (KeyValuePair<string, int> pair in statusMap.OrderBy(pair => pair.Key, StringComparer.Ordinal)) |
There was a problem hiding this comment.
I don't object to the addition of StringComparer here or the other two places, but it should probably be mentioned in the PR description since it could change the sort order
Description
Updates the codebase to build against the stable .NET 11 SDK and run all tests against .NET 11. Steeltoe itself does not need to explicitly target .NET 11 at this time.
Quality checklist
If your change affects other repositories, such as Documentation and/or Samples, add linked PRs here.