Repository navigation
Add build support for .NET 11 SDK and run all tests against .NET 11 #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,7 @@ jobs: | |
| 8.0.* | ||
| 9.0.* | ||
| 10.0.* | ||
| 11.0.* | ||
|
|
||
| - name: Git checkout | ||
| uses: actions/checkout@v7 | ||
|
|
@@ -149,7 +150,7 @@ jobs: | |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v6 | ||
| with: | ||
| dotnet-version: 10.0.* | ||
| dotnet-version: 11.0.* | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have any concern about the sign tool working with the net11 sdk? I suppose we can address it if it fails, but I don't think we'll hit this path until the pr merges |
||
|
|
||
| - name: Install code signing tool | ||
| run: dotnet tool install --global sign --prerelease | ||
|
|
@@ -209,7 +210,7 @@ jobs: | |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v6 | ||
| with: | ||
| dotnet-version: 10.0.* | ||
| dotnet-version: 11.0.* | ||
| source-url: ${{ vars.AZURE_ARTIFACTS_FEED_URL }} | ||
| env: | ||
| NUGET_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
@@ -242,7 +243,7 @@ jobs: | |
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v6 | ||
| with: | ||
| dotnet-version: 10.0.* | ||
| dotnet-version: 11.0.* | ||
|
|
||
| - name: Download signed packages | ||
| uses: actions/download-artifact@v8 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,7 @@ jobs: | |
| 8.0.* | ||
| 9.0.* | ||
| 10.0.* | ||
| 11.0.* | ||
|
|
||
| - name: Git checkout | ||
| uses: actions/checkout@v7 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ jobs: | |
| 8.0.* | ||
| 9.0.* | ||
| 10.0.* | ||
| 11.0.* | ||
|
|
||
| - name: Git checkout | ||
| uses: actions/checkout@v7 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,4 +31,8 @@ | |
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net10.0' Or '$(TargetFramework)' == 'net9.0' or '$(TargetFramework)' == 'net8.0'"> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: this line uses both |
||
| <Using Include="System.Net.Http.Json" /> | ||
| </ItemGroup> | ||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,10 @@ namespace Steeltoe.Common.Certificates.Test; | |
| /// </summary> | ||
| internal sealed class CertificateCollector : IDisposable | ||
| { | ||
| #pragma warning disable IDE0028 // Simplify collection initialization | ||
| // Justification: workaround for bug https://youtrack.jetbrains.com/issue/RSRP-505438/Collection-expression-with-with-expression-requires-language-version-preview | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I'm reading the youtrack issues correctly, your report was classified as a dupe of an issue that was fixed in 2026.3, which this PR bumps us to... Any chance this suppression isn't actually needed?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nevermind, it's fixed in the NEXT 2026.3 release |
||
| private readonly HashSet<X509Certificate2> _certificatesToDispose = new(ReferenceEqualityComparer.Instance); | ||
| #pragma warning restore IDE0028 // Simplify collection initialization | ||
| private IOptionsMonitor<CertificateOptions>? _optionsMonitor; | ||
| private string? _certificateName; | ||
| private IDisposable? _changeListener; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,15 @@ internal sealed class MySqlEntityFrameworkCorePackageResolver : PackageResolver | |
| "MySqlConnector" | ||
| ]; | ||
|
|
||
| private static readonly List<string> MicrotingAssemblyNamesWithPreviewWorkaround = | ||
| [ | ||
| "Microting.EntityFrameworkCore.MySql", | ||
| "MySqlConnector", | ||
| // Temporary workaround: The assembly name changed in the stable 10.x version, but the 11.0.0-preview.1 version doesn't contain that change yet. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need a tracking issue for dealing with this pre-release package ref & workaround? I'm assuming you wouldn't intend to ship with it and see that they plan to release in the next 7-10 days |
||
| // https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/issues/272#issuecomment-6801878626 | ||
| "Pomelo.EntityFrameworkCore.MySql" | ||
| ]; | ||
|
|
||
| private static readonly List<string> PomeloAssemblyNames = | ||
| [ | ||
| "Pomelo.EntityFrameworkCore.MySql", | ||
|
|
@@ -46,6 +55,9 @@ .. OracleAssemblyNames | |
|
|
||
| internal static readonly MySqlEntityFrameworkCorePackageResolver MicrotingOnly = new(MicrotingAssemblyNames, [MicrotingPackageName]); | ||
|
|
||
| internal static readonly MySqlEntityFrameworkCorePackageResolver MicrotingOnlyWithPreviewWorkaround = | ||
| new(MicrotingAssemblyNamesWithPreviewWorkaround, [MicrotingPackageName]); | ||
|
|
||
| internal static readonly MySqlEntityFrameworkCorePackageResolver PomeloOnly = new(PomeloAssemblyNames, [PomeloPackageName]); | ||
|
|
||
| internal static readonly MySqlEntityFrameworkCorePackageResolver OracleOnly = new(OracleAssemblyNames, [OraclePackageName]); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the removal of this newline intentional?