Skip to content

Fix responsive version-comparison modal; close already-implemented items - #967

Merged
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
laddyr141-ui:fix/issues-895-894-893-892
Oct 20, 2026
Merged

Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
laddyr141-ui:fix/issues-895-894-893-892

Conversation

@laddyr141-ui

Copy link
Copy Markdown
Contributor

Summary

  • Implement responsive design for mobile and tablet devices #894: Fixed a genuine responsive-design gap — the version-comparison diff modal (ComparisonView in src/components/VersionHistory.tsx) was hardcoded to a 2-column grid, which crammed two font-mono diff columns side by side even on narrow mobile viewports. Changed to grid-cols-1 sm:grid-cols-2 so columns stack on mobile, with matching padding tightened at small sizes.
  • Add dark mode support with theme persistence #893: Skipped — dark mode with theme persistence already exists in full (ThemeContext.tsx, ThemeToggle, localStorage persistence, system-preference listener). Commented on the issue with details.
  • Implement advanced search and filtering for invoices #892: Skipped — advanced invoice search/filtering already exists in full (status, date-range, tags, sort, saved presets, and a natural-language query parser with amount min/max support). Commented on the issue with details.
  • Add data visualization dashboards for creators #895: Skipped — creator-facing data visualization dashboards already exist extensively via recharts (multiple chart components plus a dedicated analytics/ suite). Adding another chart risked being arbitrary rather than filling a real gap. Commented on the issue with details.

Closes #895
Closes #894
Closes #893
Closes #892

Test plan

  • Open the version comparison modal on invoice history at a mobile viewport width (<640px) and confirm the before/after diff columns stack vertically instead of overflowing
  • Confirm desktop (>=640px) still shows the 2-column side-by-side diff layout

…bile

The ComparisonView diff grid in VersionHistory.tsx was hardcoded to
grid-cols-2, forcing two cramped font-mono columns side by side even
on narrow mobile viewports. Switch to grid-cols-1 sm:grid-cols-2 so
the before/after columns stack on small screens, and tighten modal
padding at the sm breakpoint.
@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

@laddyr141-ui is attempting to deploy a commit to the kingsman-99's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Kingsman-99
Kingsman-99 merged commit d8937b8 into Stellar-split:main Oct 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants