Skip to content

Fix responsive version-comparison modal; close already-implemented items #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kingsman-99 merged 1 commit into from
Oct 20, 2026
Merged

Fix responsive version-comparison modal; close already-implemented items #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/VersionHistory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ function ComparisonView({ left, right, onClose }: ComparisonViewProps) {
>
<div className="bg-gray-900 border border-gray-700 rounded-2xl w-full max-w-3xl max-h-[90vh] flex flex-col overflow-hidden shadow-2xl">
{/* Header */}
<div className="flex items-center justify-between px-6 py-4 border-b border-gray-800">
<div className="flex items-center justify-between px-4 sm:px-6 py-4 border-b border-gray-800">
<div>
<h2 className="text-lg font-bold text-white">Version Comparison</h2>
<p className="text-xs text-gray-400 mt-0.5">
Expand All @@ -218,7 +218,7 @@ function ComparisonView({ left, right, onClose }: ComparisonViewProps) {
</div>

{/* Column headers */}
<div className="grid grid-cols-2 gap-4 px-6 pt-4 pb-2">
<div className="grid grid-cols-1 sm:grid-cols-2 gap-4 px-4 sm:px-6 pt-4 pb-2">
<div className="text-xs font-semibold text-indigo-400 uppercase tracking-wide">
v{left.versionNumber} — {left.action}
</div>
Expand All @@ -228,7 +228,7 @@ function ComparisonView({ left, right, onClose }: ComparisonViewProps) {
</div>

{/* Comparison body */}
<div className="flex-1 overflow-y-auto px-6 pb-6">
<div className="flex-1 overflow-y-auto px-4 sm:px-6 pb-6">
{allFields.length === 0 ? (
<div className="py-8 text-center text-gray-500 text-sm">
No field-level changes recorded for either version.
Expand All @@ -239,7 +239,7 @@ function ComparisonView({ left, right, onClose }: ComparisonViewProps) {
const leftDiff = leftDiffs.find((d) => d.field === field);
const rightDiff = rightDiffs.find((d) => d.field === field);
return (
<div key={field} className="grid grid-cols-2 gap-4">
<div key={field} className="grid grid-cols-1 sm:grid-cols-2 gap-4">
<div className="rounded-lg border border-gray-800 overflow-hidden">
<div className="px-3 py-1.5 text-xs font-mono bg-gray-800 text-gray-400 border-b border-gray-700">
{field}
Expand Down