Skip to content

Buff two-handed weapons: x1.5 attack damage, blunt splash x0.9 - #50

Merged
XxFran10xX merged 1 commit into
mainfrom
feat/two-handed-damage-buff
Nov 1, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
feat/two-handed-damage-buff

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Why

Two-handers (longsword, greathammer, greataxe, polearm) took the metal's attack damage like one-handers, but swing at 1.2 instead of 1.6 and give up the off-hand (shortsword weapon damage/crit or shield DR, plus a second gem socket and alloy). With mythril they did about 6.0 damage per second, against 7.2–10.0 for one-hander + off-hand setups.

Change (bundled default stats.yml)

  • factors: attack_damage: 1.5 on polearm, longsword, greathammer, greataxe.
  • blunt_rating: 0.9 on greathammer and greataxe. Splash is the item's blunt_rating % of the hit (MythicLib's base 33 does not add), so this gives 45–72% (iron to mythril).

Live Main and Tutorial already run these values (applied 2026-11-01 with ac reload). The same day, MythicLib base CRITICAL_STRIKE_POWER was lowered from 200 to 150 on the servers. That isn't part of this repo.

Testing

  • Dev bot test (mythril, best-quality craft, legendary leather and wool, NoAI dummies): two-handers hit 7.5 attack damage (10.1 for a Berserker), and greathammer splash is 72% (7.3). Mythril damage per second, Berserker: greataxe 12.3 + splash vs battleaxe + shortsword 12.4.
  • mvn test: LoaderCoverageTest passes. Four tests in StationDatabaseCoverageTest/EdgeCoverageTest fail on Windows on untouched main too (file permission and temp-folder deletion), so they're unrelated.

🤖 Generated with Claude Code

Two-handers hit as hard as a one-hander but swing at 1.2 instead of 1.6
and give up the off-hand (shortsword weapon damage or shield DR, plus a
second gem socket and alloy). Longsword, greathammer, greataxe and polearm
now deal 1.5x attack damage. Greathammer and greataxe blunt_rating gets a
0.9 factor (splash 45-72% of the hit; MythicLib's base 33 does not add).

Matches the live Main/Tutorial stats.yml (applied 2026-11-01 with ac reload).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b879f0e4-578a-4162-b899-ffcac45e8a0b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Nov 1, 2026
@XxFran10xX
XxFran10xX merged commit 3179328 into main Nov 1, 2026
3 checks passed
@XxFran10xX
XxFran10xX deleted the feat/two-handed-damage-buff branch November 1, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant