Repository navigation
Build spectral libraries from charged peptide TSV - #156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
timsseek build-library --peptides peptides.tsvfor charged ProForma and protein IDs. Predict each specified modification and charge, preserve supplied decoys, and generate pseudo-reversed or seeded shuffled decoys. Generated decoys cannot match a target at any charge. Pseudo-reverse retries with shorter interior spans; if every candidate collides, the target remains unpaired.Use one numeric
msspeculator:decoy_groupfor FASTA and peptide libraries. Supplied TSV group IDs must be integers; the builder assigns unique IDs to targets without one. The mzSpecLib reader and in-memory prediction path retain numeric IDs. The olddecoy_pair_idterm is removed.TalusBio/msspeculator#18 and #19 are merged. Pinned to #19's merge commit,
3fb9dddbd848f4e7ccf3ccfc049690d2f10431a9.Checks
task fmtcargo test -p timsseek_cli --test build_library --no-default-features --offline(5 passed)cargo test -p timsquery --lib serde::mzspeclib_io --offline(34 passed)cargo test -p timsseek_cli --bin timsseek --no-default-features --offline(110 passed)cargo clippy -p timsseek_cli -p timsquery --no-default-features --all-targets --offline -- -D warnings -A clippy::redundant_closureStrict Clippy has an existing
redundant_closurewarning inrust/timsseek/src/utils/maybe_par.rs:54.