Repository navigation
🔒 Fix TOCTOU SSRF Vulnerability in URL Fetching - #253
Conversation
Remove DNS resolution from `is_safe_url` to prevent Time-of-Check to Time-of-Use SSRF vulnerabilities. URL validation now relies entirely on `SafeResolver` during the connection phase. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed preemptive DNS resolution and IP checking from
is_safe_url. IP validation now happens exclusively inSafeResolverduring the actual connection attempt inureq.🛡️ Solution:
is_safe_urlnow solely verifies the scheme and URL structure. By shifting all DNS resolution and IP filtering to the connection phase withinureq'sSafeResolver, we ensure the IP validated is the exact one being connected to, preventing the TOCTOU attack vector.PR created automatically by Jules for task 1000401122315601984 started by @Tcode-Motion