Skip to content

🔒 Fix TOCTOU SSRF Vulnerability in URL Fetching #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Oct 7, 2026
Merged

🔒 Fix TOCTOU SSRF Vulnerability in URL Fetching #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions stdlib/src/web.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,8 @@ fn is_safe_url(url_str: &str) -> bool {
_ => return false, // Block file://, ftp://, gopher://, etc.
}

let host = match parsed_url.host_str() {
Some(h) => h,
None => return false, // No host provided
};

let port = parsed_url.port_or_known_default().unwrap_or(80);
let addr_str = format!("{}:{}", host, port);

// Resolve the domain to IPs
let addrs = match addr_str.to_socket_addrs() {
Ok(a) => a,
Err(_) => return false, // DNS resolution failed
};

for addr in addrs {
if !is_safe_ip(&addr.ip()) {
return false; // Found an unsafe IP
}
if parsed_url.host_str().is_none() {
return false; // No host provided
}

true
Expand Down
Loading
Loading