Repository navigation
test(web): the agent update notice test no longer waits on a closed notice's fade - #915
Merged
Merged
Conversation
…otice's fade "brings a failure back after its notice was closed mid-run" closed the notice and waited, on the 1 s default, for it to leave the page. A closed notice stays for its 0.5 s fade (about 560 ms here), so a slow fade on a busy runner failed the test with `expected ['Updating Codex'] to deeply equal []`, as it did once in #912's CI. The titles the test reads now leave out a notice from the moment it starts closing.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
ProviderUpdateProgress.browser.tsx"brings a failure back after its notice was closed mid-run" failed once in #912's CI withexpected ['Updating Codex'] to deeply equal []. #912 only touched server code, and the test passed on a re-run.The test closes the notice and waits, on
vi.waitFor's 1 s default, for its title to leave the page. A closed notice stays in the page for its 0.5 s fade (about 560 ms on my machine), so the test had under half a second to spare.The fix
The titles the test reads now leave out a notice from the moment it starts closing (
[data-ending-style]on the toast root), so no check waits on the fade. A notice that never closes still fails the test. Only the test changed.Checked
* { transition-duration: 3s !important }), the old test fails with the exact CI message and the fixed one passes.vp fmt,vp lint,vp run typecheck, and the spec on repeated runs.The CI cause is inferred. Slowing the browser's CPU 20x and freezing the page for 900 ms did not make the fade run long locally, so what slowed it on the runner was not observed.