Skip to content

test(web): the agent update notice test no longer waits on a closed notice's fade #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badcuban merged 1 commit into from
Nov 14, 2026
+8 −1
Merged

test(web): the agent update notice test no longer waits on a closed notice's fade #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/web/src/components/ProviderUpdateProgress.browser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,15 @@ async function mountProgress() {
);
}

/**
* The titles of the notices on screen. A closed one stays in the page for the
* half second it takes to fade out, and longer on a busy machine: it stops
* counting the moment it starts leaving, so no check here waits on that fade.
*/
const noticeTitles = () =>
Array.from(document.querySelectorAll("[data-slot='toast-title']"), (el) => el.textContent);
Array.from(document.querySelectorAll("[data-slot='toast-title']"))
.filter((title) => title.closest("[data-ending-style]") === null)
.map((title) => title.textContent);

describe("ProviderUpdateProgress", () => {
afterEach(async () => {
Expand Down
Loading