Repository navigation
test(web): the panel-corner test gives a busy runner five seconds to composite the chat - #952
Merged
Merged
Conversation
…composite the chat It waited the default second for the report in which the chat's scroller is its own layer; under load in CI that can take longer, failing the setup step rather than the check. The check on the report it then reads is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #944, from Sol's review of it.
ChatView.desktop-window"rounds the panel's corner without a mask layer the size of the panel" waits for the layer report in which the chat's scroller has its own layer. That wait usedvi.waitFor's default of one second. On a busy CI runner compositing the chat can take longer, which fails the test's setup step instead of the thing it checks. It now waits up to five seconds. The check that no panel-sized layer without a node exists, on the report it then reads, is unchanged.Checked: the file passes on its own (3/3);
vp fmtandvp lintpass.