Skip to content

test(web): the panel-corner test gives a busy runner five seconds to composite the chat - #952

Merged
badcuban merged 1 commit into
mainfrom
test-panel-corner-wait
Nov 16, 2026
Merged

badcuban merged 1 commit into
mainfrom
test-panel-corner-wait

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Follow-up to #944, from Sol's review of it.

ChatView.desktop-window "rounds the panel's corner without a mask layer the size of the panel" waits for the layer report in which the chat's scroller has its own layer. That wait used vi.waitFor's default of one second. On a busy CI runner compositing the chat can take longer, which fails the test's setup step instead of the thing it checks. It now waits up to five seconds. The check that no panel-sized layer without a node exists, on the report it then reads, is unchanged.

Checked: the file passes on its own (3/3); vp fmt and vp lint pass.

…composite the chat

It waited the default second for the report in which the chat's scroller is its own layer; under load in CI that can take longer, failing the setup step rather than the check. The check on the report it then reads is unchanged.
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 16, 2026 9:53am UTC

Request Review

@badcuban
badcuban enabled auto-merge November 16, 2026 09:53
@badcuban
badcuban added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 88049d3 Nov 16, 2026
24 checks passed
@badcuban
badcuban deleted the test-panel-corner-wait branch November 16, 2026 10:04

This branch was previously deployed

1 inactive deployment
Preview — 7a83cc0c Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant