Repository navigation
refactor: make unleashconfig immutable and split params into groups - #457
Merged
Merged
Conversation
alexanto
marked this pull request as ready for review
October 23, 2026 12:07
alexanto
requested review from
ppicom and
sighphyre
and
a balanced review from Copilot
October 23, 2026 12:14
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
ppicom
reviewed
Oct 23, 2026
sighphyre
reviewed
Oct 26, 2026
alexanto
force-pushed
the
refactor/make-unleashconfig-immutable
branch
from
October 27, 2026 13:13
b79e6bf to
02baa85
Compare
alexanto
force-pushed
the
refactor/make-unleashconfig-immutable
branch
from
October 27, 2026 13:37
23510cf to
6c14dc8
Compare
alexanto
force-pushed
the
refactor/make-unleashconfig-immutable
branch
from
October 27, 2026 14:04
e742280 to
7db242c
Compare
ppicom
approved these changes
Oct 28, 2026
alexanto
force-pushed
the
refactor/make-unleashconfig-immutable
branch
from
October 28, 2026 08:24
32624c0 to
321248e
Compare
for more information, see https://pre-commit.ci
Contributor
|
Nope @sighphyre, no thoughts. LGTM! 🚢 🇮🇹 |
10 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replaces the 26 flat constructor arguments of
UnleashClientandAsyncUnleashClientwith option groups, moves the API token to its ownapi_keyargument, and makes the client's settings immutable.Planned for release in v7. This is a breaking change.
What changes:
read-only. Their nrence, becauseoptions can hold objects that can't be copied, such as an SSL
context.
Docs: readme, changelog and migration guide added.
Type of change
How Has This Been Tested?
Checklist: