Repository navigation
Conversation
This was referenced Oct 24, 2026
Collaborator
|
I don't think installing clang-format from the repos is a good idea. We require a specific, pinned version so any future update of the runner would have to remember to switch back to using Docker again. If you want something less manual, I can recommend https://github.com/jidicula/clang-format-action |
Member
|
clang-format is not backward compatible, so we must pin to a specific version + cannot upgrade from 17 without testing. |
Member
Author
|
About |
Collaborator
|
As I see it, that commit was due to an intermittent issue with the action. It took a couple of days to get fixed but has been smooth sailing ever since. With a bit more patience we needn't have switched at all :D |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatting job fails on Ubuntu 26.04 because the external LLVM 17 apt repository returns 404.
Install clang-format-17 directly from Ubuntu’s repositories.Switched back to https://github.com/jidicula/clang-format-actionUpdate the build matrix from Ubuntu 24.04 to 26.04, retaining existing ubuntu-latest runners