Skip to content

ci: use Ubuntu 26.04 and clang-format-action for formatting check - #733

Open
ajay-mk wants to merge 2 commits into
masterfrom
ajay/ci/ubuntu-26
Open

ajay-mk wants to merge 2 commits into
masterfrom
ajay/ci/ubuntu-26

Conversation

@ajay-mk

@ajay-mk ajay-mk commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

The formatting job fails on Ubuntu 26.04 because the external LLVM 17 apt repository returns 404. Install clang-format-17 directly from Ubuntu’s repositories. Switched back to https://github.com/jidicula/clang-format-action

Update the build matrix from Ubuntu 24.04 to 26.04, retaining existing ubuntu-latest runners

@Krzmbrzl

Krzmbrzl commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

I don't think installing clang-format from the repos is a good idea. We require a specific, pinned version so any future update of the runner would have to remember to switch back to using Docker again.

If you want something less manual, I can recommend https://github.com/jidicula/clang-format-action

@evaleev

evaleev commented Oct 25, 2026

Copy link
Copy Markdown
Member

clang-format is not backward compatible, so we must pin to a specific version + cannot upgrade from 17 without testing.

@ajay-mk

ajay-mk commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

About clang-format-action: this is what we used to have and ed5eb89 moved us off it. Okay to switch back?

@Krzmbrzl

Krzmbrzl commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

As I see it, that commit was due to an intermittent issue with the action. It took a couple of days to get fixed but has been smooth sailing ever since. With a bit more patience we needn't have switched at all :D

@ajay-mk ajay-mk changed the title ci: use Ubuntu 26.04 and install clang-format from Ubuntu ci: use Ubuntu 26.04 and clang-format-action for formatting check Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants