Repository navigation
feat: support using decl types for in/out - #256
Merged
Merged
Conversation
WerWolv
reviewed
Sep 10, 2026
| } else if (const auto typeDecl = dynamic_cast<ast::ASTNodeTypeDecl*>(type->getType().get()); typeDecl != nullptr) { | ||
| if (const auto enumDecl = dynamic_cast<ast::ASTNodeEnum*>(typeDecl->getType().get()); enumDecl == nullptr) { | ||
| auto visitingType = type; | ||
| auto declNestLimit = 128; // some high value so infinite recursion breaks |
Owner
There was a problem hiding this comment.
kek
This made me discover that this code is in fact valid and triggers the evaluation depth limit. I didn't think we could have recursive type definitions like that
using A;
using B = A;
using A = B;
A a @ 0x00;
WerWolv
requested changes
Sep 10, 2026
WerWolv
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought up here: WerWolv/ImHex#2890 (comment)
But
usingdecls don't work at all even for builtin types. This fixes that.