Skip to content

feat: support using decl types for in/out #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WerWolv merged 3 commits into from
Sep 13, 2026
Merged

feat: support using decl types for in/out #256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6a92b2
feat: support using decl types for in/out
neptuwunium Sep 10, 2026
441c61b
qa: requested changes
neptuwunium Sep 10, 2026
1d45e55
Merge branch 'master' into feat/in-out-using
WerWolv Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 39 additions & 11 deletions lib/source/pl/core/parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2429,22 +2429,50 @@ namespace pl::core {

if (inVariable || outVariable) {
bool invalidType = false;
if (const auto builtinType = dynamic_cast<ast::ASTNodeBuiltinType*>(type->getType().get()); builtinType != nullptr) {
if (const auto valueType = builtinType->getType(); !Token::isInteger(valueType)
&& !Token::isFloatingPoint(valueType)
&& valueType != Token::ValueType::Boolean
&& valueType != Token::ValueType::Character
&& valueType != Token::ValueType::String)
invalidType = true;
} else if (const auto typeDecl = dynamic_cast<ast::ASTNodeTypeDecl*>(type->getType().get()); typeDecl != nullptr) {
if (const auto enumDecl = dynamic_cast<ast::ASTNodeEnum*>(typeDecl->getType().get()); enumDecl == nullptr) {
auto visitingType = type;
i32 declNestLimit = 32; // default evaluation depth
while (!invalidType && visitingType && declNestLimit-- > 0) {
auto checkType = visitingType->getType();

if (checkType == nullptr) {
invalidType = true;
break;
}
} else {

if (const auto typeDecl = std::dynamic_pointer_cast<ast::ASTNodeTypeDecl>(checkType); typeDecl != nullptr) {
checkType = typeDecl->getType();
}

if (const auto usingDecl = std::dynamic_pointer_cast<ast::ASTNodeTypeApplication>(checkType); usingDecl != nullptr) {
if (usingDecl == visitingType) [[unlikely]] {
// bad case of forward declarations ending up referencing itself
invalidType = true;
Comment thread
neptuwunium marked this conversation as resolved.
break;
}

visitingType = usingDecl;
continue;
}

if (const auto enumDecl = dynamic_cast<ast::ASTNodeEnum *>(checkType.get()); enumDecl != nullptr) {
break;
}

if (const auto builtinType = dynamic_cast<ast::ASTNodeBuiltinType *>(checkType.get()); builtinType != nullptr) {
const auto valueType = builtinType->getType();
invalidType = !Token::isInteger(valueType)
&& !Token::isFloatingPoint(valueType)
&& valueType != Token::ValueType::Boolean
&& valueType != Token::ValueType::Character
&& valueType != Token::ValueType::String;
break;
}

invalidType = true;
break;
}

if (invalidType) {
if (invalidType || visitingType == nullptr || declNestLimit <= 0) {
errorDesc("Invalid in/out parameter type.", "Allowed types are: 'char', 'bool', 'str', floating point types, integral types, or enums.");
return nullptr;
}
Expand Down
Loading