Repository navigation
Translate upload filename warnings in HTML - #1670
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render translated filename and file-size warnings in hidden HTML spans, as suggested in #1660. JavaScript toggles the spans while preserving the existing validation and upload-button behavior. Related to #1660.
JavaScript syntax, English/French warning rendering, and eight handler-level validation scenarios passed. Browser testing against the local portal also passed all 16 cases in English and French using Playwright Chromium at 1280×900: invalid filenames, oversized files, combined warnings, the exact size limit, and recovery after selecting a valid file. Warnings and upload-button states were correct, with no JavaScript console errors.
No files were uploaded. The temporary test account was removed and the original upload limit restored. Mobile and other browsers were not tested. Existing English Cancel/Upload button labels and a server log-volume error are outside this change.