Repository navigation
feat(ateapi): a default egress policy on the ActorTemplate - #1868
Closed
Quentin Bisson (QuentinBisson) wants to merge 1 commit into
Closed
Quentin Bisson (QuentinBisson) wants to merge 1 commit into
Quentin Bisson (QuentinBisson) wants to merge 1 commit into
Conversation
Contributor
Author
|
One gap this does not close: the credential provider resolves Secrets per atespace, and the golden Actor boots in the reconciler's atespace ( |
Collaborator
|
Calling UpdateActor(new_template) will update the actor's template, it's not clear to me what should happen to the actor's egress policy during the update? Is it expected to merge the egress policy from the new template? |
ActorTemplate.default_egress_policy (an EgressPolicyTemplate: the rules of an EgressPolicy) is copied onto every Actor created from the template as its "default" EgressPolicy, in the same transaction as the Actor row. That covers the golden Actor the template reconciler creates, which no client can give a policy before it boots; without one atenet denies all of its egress, so a workload that fetches skills or plugins before readyz never gets its golden snapshot. A policy passed by the caller wins over the template's; a template without the field behaves as before. The copy is a snapshot: a later template change does not touch existing Actors. Refs agent-substrate#1324 Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Quentin Bisson (QuentinBisson)
force-pushed
the
upstream/actortemplate-default-egress-policy
branch
from
September 25, 2026 13:28
37b367a to
8f2c715
Compare
Contributor
Author
Bowei Du (bowei)
added
area/api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A golden Actor is created by the template reconciler, so no client can create its EgressPolicy before it boots. atenet denies every request of an Actor without a policy, and a workload that fetches skills or plugins during the golden boot (kagent-dev/kagent#2604) fails with 403 and never gets its snapshot. #1324 discusses the design.
Change
ActorTemplate.default_egress_policy, anEgressPolicyTemplate(the rules of anEgressPolicy). CreateActor copies it onto the Actor as itsdefaultpolicy in the same transaction as the Actor row; a policy the caller passes wins; a template without the field behaves as before; the copy is a snapshot. Store contract and control-API tests cover the transactional write and the precedence.