Skip to content

feat(services): publish authoritative application origins (NVIDIA/OpenShell#4956) - #19

Merged
pimlock merged 1 commit into
mainfrom
port/4956
Nov 20, 2026
Merged

pimlock merged 1 commit into
mainfrom
port/4956

Conversation

@pimlock

@pimlock pimlock commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Imports ai-openshell/openshell#4956, which changed core's sdk/typescript/ after the v0.1.9 history import: SandboxRef gains applicationServiceUrls and gatewayServiceUrls, filled from create and createFromTemplate responses. Core is replacing that directory with a re-export stub (ai-openshell/openshell#5685), so the change has to live here.

How it was imported

Like the history import and the v0.1.9 refresh: hack/migration/import-core.sh (branch migration/v0.1.9) filters core's history through 90e34ad10e42c8ef76e33f913ec485dc9196f5a7 with extract-history.sh, and merges the new filtered commit.

  • fb53fb2e is core's squash commit as it is on core's main: same author, committer, dates, and message, with bare #N qualified as NVIDIA/OpenShell#N. Its parent is f4ed506, the tip of the existing import, so no history is rewritten.
  • cd313ad6 is the signed-off merge commit that imports it.

Merge this PR with a merge commit, not squash, so the imported commit stays as it is.

DCO

fb53fb2e fails the DCO check, as it does on core's main: GitHub authored the squash commit as tmutch@nvidia.com, while its Signed-off-by trailers say taylormutch@gmail.com. Core checks only PR commits, so main accepted it. A maintainer override keeps the commit unchanged, as for ai-openshell/openshell#2884 in the history import.

Bindings

The change reads SandboxResponse.applicationServiceUrls and gatewayServiceUrls, which core added after v0.1.9, so typecheck and one unit test fail at the current pin. No core tag includes ai-openshell/openshell#4956 yet (it merged after v0.1.10-pre.2). Once the next prerelease exists, a separate commit on this branch moves the pin and regenerates the bindings.

TODO

  • Wait for the next core prerelease (v0.1.10-pre.3 or later) that includes feat(services): publish authoritative application origins openshell#4956, then add a commit that moves OPENSHELL_CORE_REF to it and regenerates the bindings (mise run proto:gen). A commit SHA can't be pinned: core-sync rejects non-tag pins, and E2E runs the gateway image published for the pinned tag.

Testing

  • The merged tree is identical to the earlier git am port of the same change, and its SDK diff has the same patch-id as core's 90e34ad10.
  • With bindings generated at core 90e34ad10 (not committed), lint, type check, and all 207 unit tests pass.
  • CI at the current pin: type check and tests fail until the pin moves.

@pimlock
pimlock requested review from a team as code owners November 20, 2026 00:30
@pimlock
pimlock marked this pull request as draft November 20, 2026 00:30
@pimlock
pimlock force-pushed the port/4956 branch 2 times, most recently from 3c23c16 to cd313ad Compare November 20, 2026 00:40
@pimlock pimlock changed the title feat(services): publish authoritative application origins chore: import NVIDIA/OpenShell#4956 from core Nov 20, 2026
@pimlock pimlock changed the title chore: import NVIDIA/OpenShell#4956 from core feat(services): publish authoritative application origins (NVIDIA/OpenShell#4956) Nov 20, 2026
…ll/openshell#4956)

* feat(services): publish authoritative application origins

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(services): align URL schema with separate discovery service

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(services): preserve replay URLs and SDK source compatibility

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* docs(server): link to application URL configuration

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* feat(services): allow disabling gateway application routing

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* chore(server): log enabled application routing modes

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(helm): use canonical service routing configuration

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* refactor(services): derive app listener domain from base URL

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(services): address application URL review feedback

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(supervisor): report app listener route rejections

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

---------

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@pimlock
pimlock merged commit 2aa5abc into main Nov 20, 2026
11 checks passed
@pimlock
pimlock deleted the port/4956 branch November 20, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants