fix(cli): compile OpenAPI path templates correctly - #55
Merged
Merged
Conversation
Rationale: Generated custom-verb paths were interpreted as extra path parameters, making production order-draft actions unusable. Preserve OpenAPI brace templates through generation and compile only declared parameters, including embedded and wildcard forms. Tested: mise run check (19 files, 177 tests); bun run generate:check; production dogfood selectWorkspace reached the API and advanced the draft.
Rationale: OpenAPI brace templates keep AIP custom verbs literal, while the Effect client must retain legacy colon parameter interpolation for dot-delimited and optional paths.\n\nTested: bun run test test/generated-command.test.ts test/generate-effect-api.test.ts test/effect-generator-patch.test.ts; bun run generate:check; mise run check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Production dogfood proved the merged #47 workaround is not router-compatible: generated order-draft custom verbs either failed as a missing path parameter in v0.10.1 or sent
%3AselectWorkspace, which production returns as 404. The same compiler also broke embedded brace parameters and wildcard proxy paths.What
{param}and{path:*}templates through generation/:paramsupportVerification
mise run check— 19 files / 177 testsbun run generate:checkorderDrafts.selectWorkspacereached the API and advanced the draft instead of failing locally or returning route 404No release/tag is included.