GH-4259: Add GeoSPARQL geometryType function - #4260
Merged
Merged
Conversation
4 tasks
edmondchuc
force-pushed
the
feat/geosparql/geometry-type
branch
from
September 25, 2026 17:24
c048cbf to
2f07d16
Compare
Member
|
For the 4 open GeoSPARQL PRs, are they all good to merge now? |
Contributor
Author
|
@afs yes, all 4 PRs are good to go! Thanks. |
Member
edmondchuc
force-pushed
the
feat/geosparql/geometry-type
branch
from
September 27, 2026 01:57
2f07d16 to
9c66efd
Compare
Contributor
Author
|
Thanks, merge conflicts resolved. |
Preserve GML source subtypes when resolving geometry types. Cache the resolved URI on GeometryWrapper and map constructed GML geometries directly from JTS types to avoid an XML serialization round trip. Add tests for GML subtypes, derived geometries, caching, and function errors.
edmondchuc
force-pushed
the
feat/geosparql/geometry-type
branch
from
September 27, 2026 08:55
4f1de76 to
2b01baa
Compare
Separate transformed WKT and GML wrappers when their lexical forms and target SRS are identical. Add a regression test for both cache insertion orders and the resulting datatype and subtype URIs.
Contributor
Author
|
Do you want me to move
|
Member
afs
approved these changes
Sep 27, 2026
Contributor
Author
|
Sure thing! |
Member
|
Done - thank you! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #4259
Add GeoSPARQL 1.1
geof:geometryType, returning the geometry subtype URI as anxsd:anyURIliteral.CurveandSurface. For constructed GML geometries, derive the type from JTS without an XML round trip.GeometryWrapper, preserving it across copy constructors while ensuring derived geometries compute their own type.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.