Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/mina/actions/runs/35831174047/job/107083881501
org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddresssometimes fails due to additional log event sneaking in without remote address:mina/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Line 702 in 0813a77
There are already some comments about logging in this file causing problems with
MdcInjectionFilterTestmina/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Line 684 in 0813a77
The disposing sessions log is quite new.
Changes
org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddresscoming fromIoProcessorloggerThe test still processes and verifies
org.apache.mina.core.filterchain.IoFilterevents such as: