Repository navigation
Reject prohibited NUL and ETX characters in sheet names - #1433
Merged
pjfanning merged 1 commit intoOct 17, 2026
Merged
Conversation
Member
|
Merged - thanks |
pjfanning
added a commit
that referenced
this pull request
Oct 17, 2026
Follow-up to #1433. The error for an invalid sheet-name char embedded the char itself, which for 0x0000 and 0x0003 is invisible in logs. Show control chars as a code point, and assert the full messages in the tests. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1432.
WorkbookUtil.validateSheetNamealready documents U+0000 and U+0003 as invalid but did not reject them. Add those two cases to the existing switch and cover both with a regression test. The patch is limited to the validator and its test.Validation:
./gradlew :poi:test --tests org.apache.poi.ss.util.TestWorkbookUtil --rerun-tasks --console=plain --no-daemonpassed (2 tests) on the current trunk base. Direct HSSF/XSSF create/rename probes passed on the earlier base. A broader:poi:test :poi-ooxml:testrun had four failures that reproduced on pristine base in this environment, so the full suite is not claimed green.AI Assistance used.