Repository navigation
Conversation
Member
|
Why? It's a client log so it should be a client log |
Member
Author
|
We should better detect both: client log + crash report or server log + crash report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client log that ends in a crash report, like Prism Launcher's log of a game that crashed on start:
Before, the client log classes came first in
Detective::$possibleLogClasses, so such a log was detected as a client log.Codex can only give a log one type, and in this case the crash report should win.
This PR moves all crash report classes to the top of the list, so a crash report is detected before any client or server log.
The generic
VanillaCrashReportLognow matches the header only at the start of a line.Forge 1.7.10 prints a system report with this header on every start (
[STDOUT/]: [cpw.mods.fml.client.SplashProgress:start:188]: ---- Minecraft Crash Report ----, described as "Loading screen debug info" and "THIS IS NOT A ERROR"), although the game did not crash.Without the anchor,
forge-1-7-10-client.logwould become a crash report.A real Forge crash logged behind a prefix (
[Render thread/FATAL] [net.minecraftforge.common.ForgeMod/]:---- Minecraft Crash Report ----) is still detected byForgeCrashReportLog, whose pattern is not anchored at the start.The pattern has no
$, because line endings are not normalized before detection.Server logs are not affected in the test data: no server log there contains a crash report header.
All other crash report detectors except Mohist's already require the header at the start of a line.
Changed expectations:
fabric-26-2-clientis nowfabric/crash-report. It loses the problem that the mod 'caxton' has thrown an exception, because the crash report analysers don't have the Fabric mod problems yet.fabric-mixin-apply-error-invalid-descriptoris nowvanilla/crash-report, because the shortened report has no brand line. It loses the fatal mixin error of 'enhanced_storage', the exception of 'rrv' and the version information.Not covered: the crash report analysers still only know ticking entity and ticking block entity problems, so mod problems in Fabric crash reports are not reported yet.
Changes
Detective