Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017CGtFm63WJtCpeBjakhwhx
…on test Adds AtlanConnectorType.DATAPLEX (needed by Connection.creator) and regenerates the two classes from the rebased models branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017CGtFm63WJtCpeBjakhwhx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Adds
creator()for the 2 Dataplex types in pyatlan_v9, following the structure of FND-3848 (Cognos).aspect_type_qn()emits. The creator takes the full GCP resource name, validates itsprojects/*/locations/*/aspectTypes/*shape, and derivesname, project and location from it, as the app does._routines_shape ({schemaQN}/_routines_/{name}). Existing routine assets carry it, and atlan-dataplex-app aspect-sync parses it.Function/Procedureinstead; the docstring says so.{conn}/{project}/{name}is a fallback bug in the Dataplex app (dataplex_enricher.py:173), not the real shape.atlan_schemarelationship, mirroringProcedure.creator.updater/trim_to_requiredon both types. Blank inputs raise (validate_required_fields).AtlanConnectorType.DATAPLEXwith categorySAAS.Connection.creatorneeds it. The app declares no category;SAASmatches the typedef'sCatalog/SaaSmodel location.pyatlan_v9/model/assets/_overlays/{gcp_dataplex_aspect_type,bigquery_routine}.py. The 2 classes are regenerated from the models PR branch with the same flags assync-python-sdk.yaml.delete_handlerin the nested converters. It comes from current models master;Referenceablealready has the field, and sync PR Sync Python SDK models from atlanhq/models #1081 adds it everywhere.BigqueryRoutine._QUALIFIED_NAME_PATTERNchanges from the generic 4-segment pattern to^.+/_routines_/[^/]+$, sovalidate()now rejects routine qns without_routines_.Linear: FND-3879
Paired models PR: https://github.com/atlanhq/models/pull/2102
Merge order
The sync bot regenerates with overlays from atlan-python
main, so in this order its PR is a no-op for these 2 types. In the other order it would regenerate them without the creators.🧩 Type of change
✅ How has this been tested?
tests_v9/unit/model/gcp_dataplex_aspect_type_test.pyandbigquery_routine_test.py(31 tests) cover:validate(for_creation=True);createalias, the updater andtrim_to_required.tests_v9/integration/dataplex_asset_test.pycreates:It retrieves each one, asserts the qualifiedName, attributes, connector and
atlan_schemalink, then purges. It passed locally against a test tenant (2 passed).pytest tests_v9/unit: 9258 passed, 5 skipped.Generator fidelity: regenerating from the models branch with these overlays reproduces the committed classes exactly, and
pre-commitleaves them unchanged.📋 Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_017CGtFm63WJtCpeBjakhwhx