Skip to content

helper: add missing f prefix in exception messages and fix a typo - #4595

Merged
joaoantoniocardoso merged 2 commits into
bluerobotics:masterfrom
nicoschmdt:fix-exception-msg-helper
Oct 14, 2026
Merged

joaoantoniocardoso merged 2 commits into
bluerobotics:masterfrom
nicoschmdt:fix-exception-msg-helper

Conversation

@nicoschmdt

Copy link
Copy Markdown
Collaborator

No description provided.

@nicoschmdt
nicoschmdt requested a review from a team October 14, 2026 17:26
@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Adds the missing f prefix to two exception-detail strings in /hardware_id and /software_id so the actual exception text is included in the HTTPException detail (instead of the literal "Error: {exception}"), and fixes a bse → be typo in the /software_id summary.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso joaoantoniocardoso added the move-to-stable Needs to be cherry-picked and move to stable label Oct 14, 2026
@joaoantoniocardoso
joaoantoniocardoso merged commit 92ea4f1 into bluerobotics:master Oct 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants