Skip to content

Link pull requests to their originating work on any bb server - #486

Closed
brsbl wants to merge 3 commits into
mainfrom
bb/prepare-pull-requests-listing-thr_dk2hhevm82
Closed

brsbl wants to merge 3 commits into
mainfrom
bb/prepare-pull-requests-listing-thr_dk2hhevm82

Conversation

@brsbl

@brsbl brsbl commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Pull Requests recognizes linked origin markers on the current server, including configured remote access addresses.
  • Plain thread-ID markers and generic thread discovery remain compatible; origin still requires accessible threads and matching repositories.
  • Adds the marketplace overview and version 0.1.1, with immutable pull-requests/ release tags enabled.

Verification

  • Focused regression tests cover another server, foreign origins, legacy markers, cached marker distrust, and repository verification.
  • Remote CI: all required checks passed.
  • Isolated bb smoke passed: same-server linked origin, foreign-server association without origin, and legacy plain-marker origin.
  • Built plugin/pull-requests artifact 00d3cb9f from 8f48e738; installed its detached checkout into fresh bb f9eae1c44.
  • Catalog hygiene and local install-artifact validation passed; no tags or install refs were pushed.

Screenshots needed

  • Queue and Summary: synthetic demo-studio/atlas repository; PR 42 “Improve keyboard navigation”, passing CI, approved review, linked “Keyboard navigation” thread. Seed an isolated bb project with that synthetic remote and a local gh fixture executable returning a synthetic viewer, search/read responses, and branch PR. Create the project through the isolated CLI, then seed one idle synthetic thread and ready environment in the fresh instance’s SQLite database; insert that synthetic thread ID into the fixture’s same-server BB-Thread marker. Start the isolated server with the fixture directory first in both its process PATH and its shell-resolved PATH. Name the source machine “Demo workstation”. Keep IDs, hostnames, paths, and account details out of the frame.
  • Stack and attention: add PR 43 “Add focus indicators” depending on PR 42 with a requested review, plus PR 44 “Handle empty search” with failing CI and a requested review. Return stack membership from the same fixture; capture the grouped queue with Needs attention enabled and the stack’s ordered Summary.
  • Read-only Changes: return a short synthetic src/navigation.ts patch from the fixture’s files response; select Changes for PR 42. Capture enough surrounding bb chrome to identify the surface without revealing identifiers.

The assigned screenshot worker owns capture and image edits. Use real isolated bb UI, synthetic content only, images at least 1200 pixels wide and at most 2 MiB. Replace the existing personal-source screenshot and update repository references when capturing.

Fixes #484

Screenshots

Before: main 0cd4457, described in text because the old images show a named machine and a thread ID · After: b0ecc31 · Captured at 2× from an isolated bb (get-bb/bb main 46da8461) with this PR's build installed from source. A fixture gh (first on the server PATH and on the shell-resolved PATH, with an empty gh config) returned a synthetic viewer and the demo-studio/atlas PRs 42–44; the "Keyboard navigation" thread was linked by bb's own branch lookup and the PR body's same-server BB-Thread marker. Machine named "Demo workstation". No GitHub account was used.

Screen / state Viewport Before After
Queue + PR Summary Desktop · 1440×900 Summary of a real PR with a named machine and thread ID (image withheld) After: Atlas queue and PR 42 Summary with passing checks, approved review, two-PR stack and the linked Keyboard navigation thread
Needs attention + stack Summary Desktop · 1440×900 Sidebar of real PRs (image withheld) After: Needs attention showing the failing Handle empty search PR, beside the stack's ordered Summary
Read-only Changes Desktop · 1440×900 Changes for a real PR (image withheld) After: Changes for PR 42 with the src/navigation.ts patch

This commit also adds docs to the package files and points the root catalog at the new images. With Needs attention on, only the failing PR 44 matches: the plugin doesn't count PR 43's pending review request as needing attention.

BB-Thread-ID: thr_dk2hhevm82

AGENT GENERATED

brsbl and others added 3 commits October 18, 2026 23:52
Replace the screenshots, which showed a named machine and a thread ID, with
captures of a synthetic demo-studio/atlas queue served by a fixture gh, and
include docs/ in the package files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brsbl

brsbl commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner Author

Superseded by #527, which ships this change together with the other plugins in one release. This PR's exact head is merged into #527 unchanged. The branch is kept.

@brsbl brsbl closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recognize pull request origins on any bb server

1 participant