Repository navigation
feat(log-viewer): show the SOQL, DML and SOSL tables in lv-grid - #1171
Open
lukecotter wants to merge 5 commits into
Open
lukecotter wants to merge 5 commits into
lukecotter wants to merge 5 commits into
Conversation
A fit-rows grid grows with its rows until --grid-max-height, then scrolls. goTo and the find bring a row into the page view, because the page, not the grid, scrolls a fitted grid.
The guard counts the selects in flight. The first async select to end no longer lets the echo of the second through.
The totals row has no statements, so it marks nothing in place of undefined.
One StatementGrid serves the three tables, with each view's columns, facets and group fields. The tables keep find, copy, CSV, column views, group by, filters, the row menu, hover locate and select from the Inspector. Remove the Tabulator helpers this leaves unused. Refs #1169
lukecotter
force-pushed
the
feat-grid-gaps
branch
from
October 16, 2026 09:10
ebc55eb to
9897659
Compare
lukecotter
force-pushed
the
feat-database-lv-grid
branch
from
October 16, 2026 09:10
4dfc96c to
7cef1f7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1169. Stacked on #1170.
What changes
The Database tab's SOQL, DML and SOSL tables move from Tabulator to lv-grid. One
StatementGridelement serves all three. Each view gives its columns, facets and group fields.The tables keep these features:
Cmd/Ctrl+C) and CSV exportUser-visible changes
Commits
feat(grid): afit-rowsgrid grows with its rows up to--grid-max-height, then scrolls.fix: the selection echo guard counts overlapping selects, so the first select to end does not let the echo of the second through.refactor: the query group cell is shared by the Call Tree and the Database tables.fix: hovering the Database time totals row in the Inspector no longer throws. This bug is also onmain.feat: the three tables on lv-grid. The Tabulator helpers that this leaves unused are removed.Tests
pnpm lint: passpnpm exec jest --selectProjects log-viewer: 2612/2612 passpnpm test:e2e:web: 2/2 pass