Skip to content

feat(log-viewer): show the SOQL, DML and SOSL tables in lv-grid - #1171

Open
lukecotter wants to merge 5 commits into
feat-grid-gapsfrom
feat-database-lv-grid
Open

lukecotter wants to merge 5 commits into
feat-grid-gapsfrom
feat-database-lv-grid

Conversation

@lukecotter

Copy link
Copy Markdown
Collaborator

Part of #1169. Stacked on #1170.

What changes

The Database tab's SOQL, DML and SOSL tables move from Tabulator to lv-grid. One StatementGrid element serves all three. Each view gives its columns, facets and group fields.

The tables keep these features:

  • find, summed across the three tables
  • copy (Cmd/Ctrl+C) and CSV export
  • column views and the column menu
  • group by, facet filters and range filters
  • the row menu ("Show in Call Tree")
  • hover locate, and select from the Inspector

User-visible changes

  • A long list scrolls inside its table, so the sections below stay in reach.
  • Selecting a statement in the Inspector scrolls its row into view when it is hidden.
  • Copy works as it does in the Call Tree.

Commits

  1. feat(grid): a fit-rows grid grows with its rows up to --grid-max-height, then scrolls.
  2. fix: the selection echo guard counts overlapping selects, so the first select to end does not let the echo of the second through.
  3. refactor: the query group cell is shared by the Call Tree and the Database tables.
  4. fix: hovering the Database time totals row in the Inspector no longer throws. This bug is also on main.
  5. feat: the three tables on lv-grid. The Tabulator helpers that this leaves unused are removed.

Tests

  • pnpm lint: pass
  • pnpm exec jest --selectProjects log-viewer: 2612/2612 pass
  • pnpm test:e2e:web: 2/2 pass
  • Dev host: the Database tables, column views and Inspector hover checked by hand.

A fit-rows grid grows with its rows until --grid-max-height, then scrolls. goTo and the find bring a row into the page view, because the page, not the grid, scrolls a fitted grid.
The guard counts the selects in flight. The first async select to end no longer lets the echo of the second through.
The totals row has no statements, so it marks nothing in place of undefined.
One StatementGrid serves the three tables, with each view's columns, facets and group fields. The tables keep find, copy, CSV, column views, group by, filters, the row menu, hover locate and select from the Inspector. Remove the Tabulator helpers this leaves unused.

Refs #1169

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant