Repository navigation
feat(log-viewer): show the Analysis table in lv-grid - #1172
Open
lukecotter wants to merge 3 commits into
Open
lukecotter wants to merge 3 commits into
lukecotter wants to merge 3 commits into
Conversation
…helpers The merged-row links, the path and mark lookups, the Bottom-Up grouping and Details filter, and the Inspector select and hover handlers move to call-tree/grid. A path now starts from the top-level row its ids name, so it does not depend on the order of the ids.
initGrid wrote the view to the grid. A host that binds its own columns then had the grid and its columns out of step.
Analysis shows the Bottom-Up grid of the Call Tree, with its own toolbar: Expand and Collapse, Details, group by, column views, find, copy and CSV. Remove the code that only the Tabulator table used. The files the grid bench's Tabulator contender imports stay until Tabulator is removed. Refs #1169
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1169. Stacked on #1171.
What changes
The Analysis tab moves from Tabulator to lv-grid. It shows the same Bottom-Up grid as the Call Tree's Bottom-Up view, with the Analysis toolbar.
The tab keeps these features:
Cmd/Ctrl+C) and CSV export (analysis.csv)User-visible changes
Commits
refactor: the merged-row helpers and the Inspector select and hover handlers move out of the Call Tree view, so Analysis uses the same code.fix: a column view applies to the columns the host holds. The Database tables had the grid and the host out of step after the first apply.feat: the Analysis table on lv-grid. Code that only the old table used is removed. The files that the grid bench's Tabulator contender imports stay until Tabulator is removed.Tests
pnpm lint: passpnpm exec jest --selectProjects log-viewer: 2613/2613 passpnpm test:e2e:web: 2/2 passpnpm bench:grid --tree bottom-up: results above