Skip to content

chore(deps)(deps): bump toml from 0.8.23 to 1.1.6+spec-1.1.0 - #131

Merged
chinkan merged 2 commits into
mainfrom
dependabot/cargo/toml-1.1.6spec-1.1.0
Oct 6, 2026
Merged

chinkan merged 2 commits into
mainfrom
dependabot/cargo/toml-1.1.6spec-1.1.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 4, 2026

Copy link
Copy Markdown
Contributor

Bumps toml from 0.8.23 to 1.1.6+spec-1.1.0.

Commits
  • 572c005 chore: Release
  • 66d0c53 docs: Update changelog
  • 07af4e7 perf: Reduce allocations in toml_edit parsing and dumping (#1215)
  • 0ff90db perf(display): Write encoded strings directly
  • efb2536 perf(display): Move generated representation strings
  • 075c444 refactor(display): Consolidate key-path encoding
  • b48f338 perf(display): Borrow table keys during document output
  • c6c1de3 perf(parser): Move completed table header keys
  • ec90463 perf(parser): Borrow input when creating editable documents
  • d76a48a test: Benchmark rendering generated keys and values
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github

dependabot Bot commented on behalf of github Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, rust. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@chinkan

chinkan commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Fix for toml 1.x CI test failures

Root cause: In toml 1.x, Value::from_str / str::parse::<toml::Value>() uses ValueDeserializer and only accepts a single value, not a full document. Config files (which often start with a blank line from raw-string fixtures, or with [table] headers) failed with unexpected content, expected nothing. Call sites: update_config_tokens in src/mcp.rs and load_doc in src/portal/settings.rs.

Change: Use toml::from_str::<toml::Value>(...) for document parses (same as toml 0.8 Value::from_str). Empty / whitespace-only input still yields Table({}).

Behaviour notes:

  • Empty config document → empty table (unchanged vs 0.8 via from_str)
  • toml::to_string_pretty round-trip formatting matches 0.8 for our samples (keys still sorted; comments still lost on Value paths — pre-existing)
  • Other call sites already used toml::from_str / to_string_pretty — no further API breaks found
  • No new regression test: existing update_config_tokens_* tests already pin the fixed path

Local verification: fmt ✅ · clippy -D warnings ✅ · test ✅ — 916 passed

New head: 3551108

@chinkan
chinkan force-pushed the dependabot/cargo/toml-1.1.6spec-1.1.0 branch 2 times, most recently from 3551108 to 2e3c893 Compare October 6, 2026 01:15

@chinkan chinkan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL ACCEPT at 2e3c893 (on main e67250d; tip may move after #132).

  • Root cause fix is correct: toml 1.x Value::FromStr is single-value only; both document parse sites (mcp::update_config_tokens, portal/settings::load_doc) now use toml::from_str
  • Scope matches the failure mode; no drive-by changes
  • Existing update_config_tokens_* coverage + PO config round-trip smoke are the right gates

Merge only after: (1) #132 lands and this PR rebases clean if lock conflicts, (2) CI green on the merge tip, (3) Product GO + QA GO on real config.toml (boot → portal settings edit/save → reboot, settings persist; comment loss OK / note it). Do not tag.

dependabot Bot and others added 2 commits October 6, 2026 09:31
Bumps [toml](https://github.com/toml-rs/toml) from 0.8.23 to 1.1.6+spec-1.1.0.
- [Commits](toml-rs/toml@toml-v0.8.23...toml-v1.1.6)

---
updated-dependencies:
- dependency-name: toml
  dependency-version: 1.1.6+spec-1.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
In toml 1.x, Value::from_str / str::parse::<Value>() only accepts a
single value (ValueDeserializer), not a full document — so config files
that start with a blank line or table headers failed with "unexpected
content, expected nothing". Switch the two document parse sites
(update_config_tokens, portal settings load_doc) to toml::from_str,
which matches 0.8 Value::from_str behaviour (empty → Table({})).
@chinkan
chinkan force-pushed the dependabot/cargo/toml-1.1.6spec-1.1.0 branch from 2e3c893 to d55262b Compare October 6, 2026 01:33

@chinkan chinkan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL ACCEPT reaffirmed at d55262b (rebase onto 117e166 after #132).

Same scope as before: toml 1.x with toml::from_str in mcp + portal settings. Merge after CI green + Product GO + QA config.toml smoke (boot → settings save → reboot). Tip may need another rebase after later merges. Do not tag.

@chinkan
chinkan merged commit 4036568 into main Oct 6, 2026
14 of 15 checks passed
@dependabot
dependabot Bot deleted the dependabot/cargo/toml-1.1.6spec-1.1.0 branch October 6, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant