Repository navigation
chore(deps)(deps): bump toml from 0.8.23 to 1.1.6+spec-1.1.0 - #131
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Fix for toml 1.x CI test failuresRoot cause: In toml 1.x, Change: Use Behaviour notes:
Local verification: fmt ✅ · clippy New head: |
3551108 to
2e3c893
Compare
chinkan
left a comment
There was a problem hiding this comment.
TL ACCEPT at 2e3c893 (on main e67250d; tip may move after #132).
- Root cause fix is correct: toml 1.x
Value::FromStris single-value only; both document parse sites (mcp::update_config_tokens,portal/settings::load_doc) now usetoml::from_str - Scope matches the failure mode; no drive-by changes
- Existing
update_config_tokens_*coverage + PO config round-trip smoke are the right gates
Merge only after: (1) #132 lands and this PR rebases clean if lock conflicts, (2) CI green on the merge tip, (3) Product GO + QA GO on real config.toml (boot → portal settings edit/save → reboot, settings persist; comment loss OK / note it). Do not tag.
Bumps [toml](https://github.com/toml-rs/toml) from 0.8.23 to 1.1.6+spec-1.1.0. - [Commits](toml-rs/toml@toml-v0.8.23...toml-v1.1.6) --- updated-dependencies: - dependency-name: toml dependency-version: 1.1.6+spec-1.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
In toml 1.x, Value::from_str / str::parse::<Value>() only accepts a
single value (ValueDeserializer), not a full document — so config files
that start with a blank line or table headers failed with "unexpected
content, expected nothing". Switch the two document parse sites
(update_config_tokens, portal settings load_doc) to toml::from_str,
which matches 0.8 Value::from_str behaviour (empty → Table({})).
2e3c893 to
d55262b
Compare
chinkan
left a comment
There was a problem hiding this comment.
TL ACCEPT reaffirmed at d55262b (rebase onto 117e166 after #132).
Same scope as before: toml 1.x with toml::from_str in mcp + portal settings. Merge after CI green + Product GO + QA config.toml smoke (boot → settings save → reboot). Tip may need another rebase after later merges. Do not tag.
Bumps toml from 0.8.23 to 1.1.6+spec-1.1.0.
Commits
572c005chore: Release66d0c53docs: Update changelog07af4e7perf: Reduce allocations in toml_edit parsing and dumping (#1215)0ff90dbperf(display): Write encoded strings directlyefb2536perf(display): Move generated representation strings075c444refactor(display): Consolidate key-path encodingb48f338perf(display): Borrow table keys during document outputc6c1de3perf(parser): Move completed table header keysec90463perf(parser): Borrow input when creating editable documentsd76a48atest: Benchmark rendering generated keys and valuesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)