Skip to content

fix(build): keep Cloudflare runtime unenv within its preset peer - #122

Merged
chrisohearn merged 1 commit into
integration/mcp-events-20261109from
fix/unenv-preset-peer-20261114
Nov 15, 2026
Merged

chrisohearn merged 1 commit into
integration/mcp-events-20261109from
fix/unenv-preset-peer-20261114

Conversation

@chrisohearn

Copy link
Copy Markdown
Owner

Fresh release installs resolve unenv RC25, while @cloudflare/unenv-preset@2.16.2 requires exactly RC24. This makes the lockfile-regenerating Release Smoke fail.

Constrain only @alchemy.run/cloudflare-runtime@2.0.0-beta.85's unenv dependency to RC24, matching the existing lockfile and preset peer. strictPeerDependencies remains enabled. The lockfile changes only to record this override.

Validation: frozen install, node scripts/release-smoke.ts (including fresh lockfile generation), vp run check:changed origin/integration/mcp-events-20261109, and git diff --check pass. The prior failing integration run and its one retry are retained at https://github.com/chrisohearn/t3code/actions/runs/43650385285/attempts/2.

Authored with GPT-6.1 Sol through Codex in T3 Code.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T23:47:20.189664Z 3080d0e PR opened
🔒 Security Review ✅ Completed 2026-11-14T23:48:39.828634Z 3080d0e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrisohearn

Copy link
Copy Markdown
Owner Author

Superseded by #123, the upstream-authored compatibility fix selected for this release. This PR was not merged or published; release work will continue through #123.

@chrisohearn chrisohearn reopened this Nov 14, 2026
@chrisohearn

Copy link
Copy Markdown
Owner Author

Coordination reconciled: this is the single repair candidate for the release. #123 remains closed. This unchanged head confines the compatibility pin to the demonstrated Alchemy runtime dependency edge, preserving strict peer checks. Existing exact-head code/security reviews and local Release Smoke/check:changed proof remain applicable; the current hosted CI must pass before merge.

@chrisohearn
chrisohearn merged commit 0558ec4 into integration/mcp-events-20261109 Nov 15, 2026
26 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants