Repository navigation
fix(ci): pin unenv so release smoke installs resolve its exact peer - #123
Closed
chrisohearn wants to merge 1 commit into
Closed
chrisohearn wants to merge 1 commit into
chrisohearn wants to merge 1 commit into
Conversation
…ingdotgg#36638) (cherry picked from commit 8a072ca)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Closing as a duplicate of #122, which carries the same unenv repair and is owned by the hourly sync thread that publishes and installs the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks upstream
pingdotgg/t3codecommit 8a072ca ("fix(ci): pin unenv so release smoke installs resolve its exact peer", upstream pingdotgg#36638) onto the integration branch.What broke
Fork integration CI failed on 11a166e (#120) in Release Smoke, which the PR checks skip. Release smoke deletes the lockfile and re-resolves it, and the fresh resolve now takes
unenv@2.0.0-rc.25, while@cloudflare/unenv-preset@2.16.2peers on exactly2.0.0-rc.24. WithstrictPeerDependencies: truethe install stops:The failure is registry drift, unrelated to #120's change.
Fix
Upstream's override, unchanged:
unenv: 2.0.0-rc.24inpnpm-workspace.yamloverrides, plus the matching lockfile line. Upstream nightly 4695 already contains it, so a later upstream merge takes it cleanly.Checks
node scripts/release-smoke.tson the base (without the pin): exit 1,ERR_PNPM_PEER_DEP_ISSUES ... unmet peer unenv, the same failure as CI.pnpm install --frozen-lockfilewith this commit: ok.🤖 Generated with Claude Code