Skip to content

fix(ci): pin unenv so release smoke installs resolve its exact peer - #123

Closed
chrisohearn wants to merge 1 commit into
integration/mcp-events-20261109from
fix/ci-pin-unenv
Closed

chrisohearn wants to merge 1 commit into
integration/mcp-events-20261109from
fix/ci-pin-unenv

Conversation

@chrisohearn

Copy link
Copy Markdown
Owner

Cherry-picks upstream pingdotgg/t3code commit 8a072ca ("fix(ci): pin unenv so release smoke installs resolve its exact peer", upstream pingdotgg#36638) onto the integration branch.

What broke

Fork integration CI failed on 11a166e (#120) in Release Smoke, which the PR checks skip. Release smoke deletes the lockfile and re-resolves it, and the fresh resolve now takes unenv@2.0.0-rc.25, while @cloudflare/unenv-preset@2.16.2 peers on exactly 2.0.0-rc.24. With strictPeerDependencies: true the install stops:

[ERR_PNPM_PEER_DEP_ISSUES] Unmet peer dependencies
infra/relay
  ✕ unmet peer unenv

The failure is registry drift, unrelated to #120's change.

Fix

Upstream's override, unchanged: unenv: 2.0.0-rc.24 in pnpm-workspace.yaml overrides, plus the matching lockfile line. Upstream nightly 4695 already contains it, so a later upstream merge takes it cleanly.

Checks

  • node scripts/release-smoke.ts on the base (without the pin): exit 1, ERR_PNPM_PEER_DEP_ISSUES ... unmet peer unenv, the same failure as CI.
  • The same command with this commit: exit 0, "Release smoke checks passed."
  • pnpm install --frozen-lockfile with this commit: ok.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T23:49:08.555672Z c4d394d PR opened
🔒 Security Review ✅ Completed 2026-11-14T23:50:28.535926Z c4d394d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chrisohearn

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #122, which carries the same unenv repair and is owned by the hourly sync thread that publishes and installs the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants