Skip to content

feat(stack-kms-azure): Azure Key Vault and Managed HSM key vendor backend (CIP-5309) - #1531

Closed
freshtonic wants to merge 1 commit into
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcpfrom
james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure
Closed

freshtonic wants to merge 1 commit into
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcpfrom
james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure

Conversation

@freshtonic

@freshtonic freshtonic commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Layer 7 of the CIP-5203 stack. Implements CIP-5309.

  • New crate stack-kms-azure: Key Vault REST 7.4 wrapkey/unwrapkey. RSA keys use RSA-OAEP-256; Managed HSM oct-HSM keys use A256KW. Both key modes.
  • Azure has no AAD, so the AAD is bound with stack_kms_vendor::bound. The wrapped key is padded to 72 bytes.
  • The stored form carries the versioned kid, so an unwrap needs no extra lookup.
  • Credentials: client secret, workload identity, managed identity (IMDS and App Service), and a static token. Client-certificate auth is deferred.
  • The shipped crate does not use rsa; it is only a dev-dependency, used by the emulator.
  • Opt-in live workflow integration-azure-key-vault.yml. It needs the variable STACK_KMS_AZURE_LIVE_KEY (optionally also STACK_KMS_AZURE_LIVE_HSM_KEY) and the secrets STACK_KMS_AZURE_TENANT_ID, STACK_KMS_AZURE_CLIENT_ID and STACK_KMS_AZURE_CLIENT_SECRET.

Decisions are in docs/plans/2026-11-05-key-vendor-backends-decisions.md (CIP-5309 section).

@freshtonic
freshtonic added this pull request to stack #1523 November 6, 2026 00:47
@freshtonic freshtonic changed the title james/cip 5309 azure key vault key vendor backend stack kms azure feat(stack-kms-azure): Azure Key Vault and Managed HSM key vendor backend (CIP-5309) Nov 6, 2026
@changeset-bot

changeset-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c905ced

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

No mutants were generated for the changed lines.

@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 1d6b20b to fb22d06 Compare November 6, 2026 02:15
@freshtonic
freshtonic force-pushed the james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure branch 2 times, most recently from d375388 to c6c6614 Compare November 6, 2026 05:10
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch 2 times, most recently from 73a5153 to 5663ebf Compare November 6, 2026 05:13
@freshtonic
freshtonic force-pushed the james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure branch 2 times, most recently from d6e2eda to 9ca407d Compare November 9, 2026 04:16
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 5663ebf to 24ee92a Compare November 9, 2026 04:16
@freshtonic
freshtonic removed this pull request from stack #1523 November 9, 2026 04:17
@freshtonic
freshtonic added this pull request to stack #1579 November 9, 2026 04:17
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 24ee92a to a5f115d Compare November 10, 2026 02:37
@freshtonic
freshtonic force-pushed the james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure branch from 9ca407d to 9d9c90e Compare November 10, 2026 02:37
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from a5f115d to fced2d9 Compare November 12, 2026 03:44
@freshtonic
freshtonic force-pushed the james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure branch from 9d9c90e to 780fdff Compare November 12, 2026 03:44
@freshtonic
freshtonic removed this pull request from stack #1579 November 12, 2026 03:45
@freshtonic
freshtonic added this pull request to stack #1623 November 12, 2026 03:47
@freshtonic

Copy link
Copy Markdown
Contributor Author

Scope reduced (2026-11-12). This branch was rebuilt from one final tree by path, and the follow-up PRs #1555 to #1563 were folded in. The plan is docs/plans/2026-11-12-key-vendor-backends-scope-reduction.md; the decision log's "Scope reduction" section records each change. Decisions: no stack-encrypt change, no v2 leaf, and the wrapped data key mode deferred.

In this PR: no same_key. The AAD fixtures were computed again by a separate script. The fixture key name fix (#1555) is folded in.

@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from fced2d9 to bd27363 Compare November 12, 2026 05:24
@freshtonic

Copy link
Copy Markdown
Contributor Author

Replaced by #1629, in the new stack #1633. The code is the same, rebased onto the latest next. The ADRs are now ADR-0013 and ADR-0014, and the text about the wrapped data key mode is removed.

@freshtonic freshtonic closed this Nov 12, 2026
@freshtonic
freshtonic deleted the james/cip-5309-azure-key-vault-key-vendor-backend-stack-kms-azure branch November 12, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant