Repository navigation
test(stack-kms-azure): name the fixture AES key the vendor key - #1555
freshtonic wants to merge 1 commit into
Conversation
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
0605831 to
0c85849
Compare
5a564a3 to
0e3e986
Compare
The emulator's AES key-wrap helpers called the key a KEK. CONTEXT.md lists KEK as a term to avoid: the vendor key is the key that wraps. Rename TEST_ONLY_KEK to TEST_ONLY_VENDOR_KEY and the kek parameters to vendor_key.
0e3e986 to
abf6a63
Compare
|
Folded into #1531 (the fixture AES key is named the vendor key). The plan is |
Summary
Test-only rename. The Azure Key Vault emulator in the tests called its AES wrapping key a "KEK". The project glossary (
packages/stack-encrypt/CONTEXT.md) lists KEK as a term to avoid, because in this design the vendor key is the key that wraps. No behaviour changes.Changes
packages/stack-kms-azure/tests:TEST_ONLY_KEKis nowTEST_ONLY_VENDOR_KEY, and thekekparameters arevendor_key.Verification
mise x --env test -- cargo nextest run -p stack-kms-azure --all-features: 57 of 57 pass.cargo clippy -p stack-kms-azure --all-features --all-targets -- -D warningsandcargo fmt --check: pass.Related
Refs #1541 (the PR below this one in the stack). Code-smell follow-up to the key vendor backend stack.