Conversation
Kewe63
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 13, 2026 07:12
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkipComparecontract in the customhexEqualmatcherFixes #399
Root cause
types.d.tsallowsSkipCompareas thehexEqualargument, butsupportHexEqual()validated the sentinel object withisHex()before applying any skip behavior. The generic skippable plugin only wraps built-in comparison methods, so it could not intercept the custom matcher.Changes
SkipComparebefore validating hexadecimal operandshexEqual(skipCompare)in the existing matcher test suiteTesting
npx hardhat test ./tests/helpers/matchers/index.test.ts --no-compile14 passing, 1 failingskipComparewas rejected as an invalid hex stringnpx hardhat test ./tests/helpers/matchers/index.test.ts --no-compile15 passingmake test-unit-hardhat37 passingnpx eslint tests/helpers/matchers/Hex.ts tests/helpers/matchers/index.test.tsnpx prettier --check tests/helpers/matchers/Hex.ts tests/helpers/matchers/index.test.tsRisk
Low. The early return applies only to the existing
SkipComparesentinel. Normal equality, inequality, case-insensitive comparison, and invalid-hex validation retain their existing paths and coverage.