Skip to content

feat: run Vite and Vite+ commands with the released Workers SDK - #540

Open
petebacondarwin wants to merge 24 commits into
mainfrom
codex/native-vite-fallback
Open

petebacondarwin wants to merge 24 commits into
mainfrom
codex/native-vite-fallback

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Run the Vite or Vite+ dev/build commands selected by autoconfig instead of requiring the internal cf-vite executable. Consume the published Workers SDK packages, including @cloudflare/autoconfig@0.13.0, with the matching configuration API and Build Output v1 migration.

Resolve executables through autoconfig's ordered application-to-workspace nodeModulesPaths, and validate missing tools and plugin compatibility after setup, at the dev/build execution boundary. Preserve canonical framework commands, Pages and unsupported-project guards, migration checks, argument/mode forwarding, Preview context, and credential isolation. Let Vite evaluate dynamic configurations and custom config files. Suggest checking cloudflare() only when a successful Vite build produces no Build Output; retain other validation errors.

Adopt the released config and Build Output packages together so the bundled CLI and autoconfig use compatible exports. Update deployment, Preview, triggers, assets-only output, and their tests for Build Output v1, including nested account settings and producer metadata. Preserve the Container deployment default of 20 instances. Starters use the Vite plugin RC and current Vitest plugin; Wrangler delegates require 4.163.0 or newer.

Breaking compatibility changes: rebuild beta Build Output before using --prebuilt. Vite projects need @cloudflare/vite-plugin@2.0.0-rc.0 or newer. The cf/config export adopts the RC API: use experimental.firstPartyWorker, bindings.pipeline({ streamId }), bindings.k2({ id }), and bindings.analyticsSql(). The changeset describes these migrations.

Keep the Vite plugin's binding defaults unchanged. Starters use cloudflare(), and users can explicitly disable remote bindings in their plugin configuration. Removing cf-vite removes its optional --local override without changing the default. Preserve migration's Vite detection by reading declared dependencies independently of the delegate registry.

Forward shutdown signals to the command tree and attempt cleanup when cf exits early. POSIX uses a separate process group, forwards SIGHUP, and escalates repeated interrupts. With inherited terminal streams, global-to-local cf delegation relies on the terminal's SIGINT delivery, so the first Ctrl+C allows the local tool to finish cleanup. Non-interactive delegation relays SIGINT, and SIGTERM is always relayed. With a terminal attached, programmatic shutdown should use SIGTERM: a SIGINT sent only to the global cf PID cannot be distinguished from terminal delivery. Windows retains console Ctrl+C delivery and uses tree termination for SIGTERM. Cleanup cannot run if cf receives SIGKILL.

Release order: autoconfig 0.13.0, containing workers-sdk#16803, is published. Merge this PR, then the cf release-channel switch in #634, and publish cf before removing cf-vite in workers-sdk#16759.

  • Use the released SDK npm packages, regenerate the lockfile, and remove the three temporary autoconfig dependency overrides.
  • Record the minimum compatible cf release on the cf-vite removal PR before merging/releasing that removal.

Validation (Node.js 22.23.4, pnpm 12.20.0), against published npm packages:

  • Full cf CLI suite: 2,907 tests passed; 10 skipped.
  • Wrangler compatibility suite: 657 tests passed, with 3,409 existing skips and 1,507 existing todos.
  • Exact root pnpm check: all seven tasks passed. Generated files have no diff; git diff --check passed.
  • Production CLI smoke: cf dev --mode test -- --port 0 --host 127.0.0.1 selected vp dev, served Test var from /var, and stopped on Ctrl+C. Normal and Preview cf build --mode test selected vp build and produced Build Output v1 with the expected mode, binding value, and build context.
  • CI on this update is pending.

@ask-bonk

ask-bonk Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@pkg-pr-new

pkg-pr-new Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@540

commit: 75c3753

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 222.3 ms 3.2 ms 218.0 ms 227.6 ms
base 226.9 ms 7.5 ms 220.2 ms 252.3 ms

Δ (PR vs base): ↓ -4.5 ms (-2.0%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@petebacondarwin
petebacondarwin marked this pull request as ready for review November 9, 2026 13:41
@petebacondarwin
petebacondarwin requested a review from a team as a code owner November 9, 2026 13:41
@petebacondarwin
petebacondarwin force-pushed the codex/native-vite-fallback branch from 4c962ab to 61791ce Compare November 9, 2026 13:41
@ask-bonk

ask-bonk Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 297d2290.

This review, of 61791ce9

✅ Approved — No problems found. The native Vite lookup matches how the plugin is found, the subprocess handling is unchanged, and tests cover the missing-Vite and parent-folder cases.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. A minor changeset fits a pre-1.0 behaviour change.


🔒 Security: ✅ LGTM

No issues found. Vite is looked up only inside the project, not in parent folders.


📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

No issues found.


⚡ Performance: ✅ LGTM

No issues found.


📝 Documentation: ✅ LGTM

The architecture doc, the AGENTS.md line and the changeset all describe the native Vite fallback correctly.


Reviewed commit: 61791ce9

@ask-bonk

ask-bonk Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of e0307a01.

This review, of 297d2290

✅ Approved — No problems found. The project's own Vite is found the same way the plugin is, process handling is unchanged, and the test update only repoints fixtures and adds a check for the install hint.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. The repository's changeset rules use minor for behaviour changes before 1.0, so a minor changeset fits.


🔒 Security: ✅ LGTM

No issues found. The path to Vite is built from fixed parts inside the project, with no user input, and parent folders are not searched. Commands are still started with an argument array and no shell.


📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

No issues found.

  • resolveViteBinary looks for node_modules/vite/bin/vite.js in the project folder, the same way plugins are found.
  • Process handling is unchanged, apart from comments.
  • The new error for a missing Vite, and its install hint, have tests.
  • Since the last review, dev/index.test.ts only points its fixtures at vite.js instead of cf-vite and adds a check for the install hint.

⚡ Performance: ✅ LGTM

No issues found. The change adds one existsSync call per command, before a long-running process starts.


📝 Documentation: ✅ LGTM

The architecture doc, the AGENTS.md line and the changeset all describe the native Vite fallback correctly.


Reviewed commit: 297d2290

@petebacondarwin petebacondarwin changed the title fix: run Vite fallbacks without cf-vite fix: run Vite and Vite+ commands selected by autoconfig Nov 9, 2026

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 6a3f45b1.

This review, of e0307a01

💬 Approved with comments — One WARNING: the detached POSIX process group can leave a dev server orphaned when the terminal closes or cf dies. There is also one INFO about the pre-release autoconfig pin, which must be replaced before shipping.

Findings: 1 warning · 1 info (2 are inline comments on the diff)

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #540.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## WARNING (1)

### [Code Quality] Detached POSIX command group is orphaned when the terminal closes (SIGHUP) or cf dies, and a second Ctrl+C no longer escalates.
- **File:** packages/cli/src/lib/autoconfig.ts:197

## INFO (1)

### [Release] @cloudflare/autoconfig is pinned to a pkg.pr.new commit build; replace it with the released version before publishing cf.
- **File:** packages/cli/package.json:83

🚀 Release: 💬 1 info

A minor changeset is present; the pre-release autoconfig pin must be replaced before shipping.

Recommendation: 💬 Optional Nits

  • [INFO] @​cloudflare/autoconfig is pinned to a pkg.pr.new commit build; replace it with the released version before publishing cf. (packages/cli/package.json:83)
View full review

Risk: Low. A minor changeset is right for a behaviour change before 1.0. @cloudflare/autoconfig is pinned to a pkg.pr.new commit build. The description plans to replace it with a registry release before cf ships, and Vite+ selection depends on that upstream change.


📋 Code Quality: ⚠️ 1 warning

Routing Vite/Vite+ through autoconfig is correct; the detached POSIX process group has lifecycle gaps.

Recommendation: 📝 Minor Comments

  • [WARNING] Detached POSIX command group is orphaned when the terminal closes (SIGHUP) or cf dies, and a second Ctrl+C no longer escalates. (packages/cli/src/lib/autoconfig.ts:197)
View full review
  • packages/cli/src/lib/autoconfig.ts:197: detached: true puts the framework command in a new session (setsid). Only SIGINT and SIGTERM are relayed to it (lines 229-232).
    • If the terminal closes, cf gets SIGHUP and exits, but the detached group does not get the hangup.
    • The same happens if cf crashes or is SIGKILLed.
    • In both cases vite/vp dev keeps running and holds its port. Before this change, the child shared cf's terminal session and would have received the hangup.
  • After the first relayed signal, controller.terminate returns early (process.ts:75-81). A second Ctrl+C therefore no longer reaches the child or escalates; nothing happens until the 5s SIGKILL fallback fires.
  • SIGINT now also arms that 5s SIGKILL fallback.
  • runProjectCommand is shared with the init install command, so installs are detached too.
  • The PATH handling is sound: the PATH/Path key is found case-insensitively, and ancestor .bin directories are prepended.

✅ All other checks passed

🔒 Security: ✅ LGTM

  • Project commands are parsed with shell-quote, operators are rejected, and the command runs as an argv array with no shell.
  • CLOUDFLARE_CF_AUTH is set after the dotenv overrides are applied, and no new secrets enter the child's environment.
  • The Windows taskkill.exe call passes its arguments as an array and uses a numeric pid.
  • The new dependency overrides keep blockExoticSubdeps, and the pre-release autoconfig URL is pinned to a full commit SHA.

📖 AGENTS.md: ✅ LGTM

No issues found.


⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The architecture doc, the AGENTS.md line and the changeset describe how cf now runs the Vite and Vite+ commands that autoconfig selects.


Reviewed commit: e0307a01

Comment thread packages/cli/src/lib/autoconfig.ts Resolved
Comment thread packages/cli/package.json Resolved

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of e36d270d.

This review, of 6a3f45b1

💬 Approved with comments — One WARNING remains: the detached POSIX process group can leave a dev server orphaned on SIGHUP or when cf is killed. There is also one INFO about the pre-release autoconfig pin, which must be replaced before shipping.

Findings: 1 warning · 1 info (1 is an inline comment on the diff)

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #540.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## WARNING (1)

### [Code Quality] Detached POSIX command group is orphaned when the terminal closes (SIGHUP) or cf dies, and a second Ctrl+C no longer escalates.
- **File:** packages/cli/src/lib/autoconfig.ts:197

## INFO (1)

### [Release] @cloudflare/autoconfig is pinned to a pkg.pr.new commit build; replace it with the released version before publishing cf.
- **File:** packages/cli/package.json:83

🚀 Release: 💬 1 info

The pre-release autoconfig pin must be replaced before shipping cf.

Recommendation: 💬 Optional Nits

  • [INFO] @​cloudflare/autoconfig is pinned to a pkg.pr.new commit build; replace it with the released version before publishing cf. (packages/cli/package.json:83)
View full review

Risk: Low. A minor changeset is right for this behaviour change. @cloudflare/autoconfig is still pinned to a pkg.pr.new commit build, and Vite+ selection depends on that upstream change.


📋 Code Quality: ⚠️ 1 warning

The detached POSIX process group can still be orphaned, and a repeated signal does not escalate.

Recommendation: 📝 Minor Comments

  • [WARNING] Detached POSIX command group is orphaned when the terminal closes (SIGHUP) or cf dies, and a second Ctrl+C no longer escalates. (packages/cli/src/lib/autoconfig.ts:197)
View full review
  • packages/cli/src/lib/autoconfig.ts:197: detached: process.platform !== "win32" starts the framework command in its own session. cf relays only SIGINT and SIGTERM to it (lines 228-231).
    • If the terminal closes, cf gets SIGHUP and exits, but the group never gets the hangup.
    • The same happens if cf crashes or is SIGKILLed.
    • In both cases vite or vp dev keeps running and holds its port.
  • controller.terminate returns early once terminationRequested is set (process.ts:75-81). A second Ctrl+C therefore does nothing until the 5s SIGKILL fallback fires.
  • runProjectCommand is also used for init installs, so those run detached as well.

✅ All other checks passed

🔒 Security: ✅ LGTM

  • Project commands still run as an argv array with no shell.
  • CLOUDFLARE_CF_AUTH is set after the dotenv overrides are applied.
  • The PATH prepend adds only the project's own and ancestor node_modules/.bin directories.
  • The taskkill.exe call takes an argv array and a numeric pid.

📖 AGENTS.md: ✅ LGTM

No issues found.


⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The architecture doc, the CLI AGENTS.md line and the changeset describe how cf now runs the Vite and Vite+ commands that autoconfig selects.


Reviewed commit: 6a3f45b1

Comment thread packages/cli/package.json Resolved

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 7377dc6d.

This review, of e36d270d

✅ Approved — The earlier warning about orphaned POSIX command groups is fixed with SIGHUP relay, escalation on repeated signals, and exit-time cleanup. No new issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. A minor changeset fits this behaviour change. @cloudflare/autoconfig is still pinned to a pre-release commit build and should be replaced with the released version before publishing cf.


🔒 Security: ✅ LGTM

No security issues found:

  • Project commands still run as an argv array with no shell.
  • CLOUDFLARE_CF_AUTH is applied after the dotenv overrides.
  • The PATH prepend adds only the project's and ancestors' node_modules/.bin.
  • Group kills target only the child's own process group.

📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

The detached POSIX command group now gets SIGHUP, and a repeated signal is escalated to SIGKILL. The group is also force-killed when cf exits first (packages/cli/src/lib/autoconfig.ts:216-249, packages/cli/src/lib/process.ts).


⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The architecture doc, the CLI AGENTS.md and the changeset describe how cf now runs the Vite and Vite+ commands that autoconfig selects.


Reviewed commit: e36d270d

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 32ae58a4.

This review, of 7377dc6d

✅ Approved — No new issues in the changes since the last review. Native Vite/Vite+ command selection, the process-tree shutdown and the credential boundaries look correct.

Not opened by the correctness review: 1 changed file it was meant to read
  • pnpm-workspace.yaml

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. A minor changeset fits this behaviour change. The @cloudflare/autoconfig commit-build pin must be replaced with the released version before cf ships.


🔒 Security: ✅ LGTM

No security problems found:

  • Commands run as argv arrays with no shell.
  • CLOUDFLARE_CF_AUTH is applied after the dotenv overrides.
  • Group kills target only the child's own process group.
  • blockExoticSubdeps is still set.

📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

The changed code has no problems:

  • Shutdown: runProjectCommand and the process controller handle group signalling, escalation on repeated signals, exit-time cleanup and listener removal correctly. On Windows, the process tree is terminated with taskkill.
  • Vite+: Native Vite+ support comes from the vp command that autoconfig selects.

⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The changeset, docs/architecture.md and the CLI AGENTS.md describe the native command selection.


Reviewed commit: 7377dc6d

@ask-bonk

ask-bonk Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of ae6403e4.

This review, of 32ae58a4

💬 Approved with comments — No defects found in the changes since the last review. One informational note: the autoconfig commit-build pin must be replaced with the released version before cf ships.

Findings: 1 info (1 is an inline comment on the diff)

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


🚀 Release: 💬 1 info

One pre-release follow-up: replace the autoconfig commit-build pin

Recommendation: 💬 Optional Nits

  • [INFO] Replace the autoconfig commit-build pin with the released version before publishing cf. (packages/cli/package.json:83)
View full review

Risk: Low. A minor changeset fits this behaviour change. packages/cli/package.json:83 pins autoconfig to a pkg.pr.new commit build. Replace it with the released version before publishing cf.


✅ All other checks passed

🔒 Security: ✅ LGTM

  • Commands run as argv arrays with no shell.
  • Group kills target only the child's own process group.
  • The scoped pnpm-workspace.yaml overrides pin autoconfig's shared dependencies to registry versions.

📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

  • Shutdown: group signalling, escalation on repeated signals, exit-time cleanup and listener removal are handled correctly.
  • Environment: CLOUDFLARE_CF_AUTH is set after options.env. Local .bin directories are prepended to the inherited PATH.
  • Plugin version check: it raises an error only for installed v2 versions older than the minimum.

⚡ Performance: ✅ LGTM

No performance concerns. The shutdown work runs only at shutdown, and the startup checks run once.


📝 Documentation: ✅ LGTM

The changeset, docs/architecture.md and the CLI AGENTS.md describe the native command selection.


Reviewed commit: 32ae58a4

Comment thread packages/cli/package.json Resolved
Comment thread docs/architecture.md Resolved
@ask-bonk

ask-bonk Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.

Posted 1 inline finding.

github run

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 9148e972.

This review, of ae6403e4

💬 Approved with comments — No defects found in the changes since the last review. One informational release note (replace the autoconfig commit-build pin) and one optional suggestion remain.

Findings: 1 info · 1 suggestion (2 are inline comments on the diff)

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


🚀 Release: 💬 1 info

Replace the autoconfig commit-build pin with the released version before publishing cf.

Recommendation: 💬 Optional Nits

  • [INFO] Replace the autoconfig commit-build pin with the released version before publishing cf (packages/cli/package.json:83)
View full review

Risk: Low. A minor changeset fits this behaviour change. packages/cli/package.json:83 still pins autoconfig to a pkg.pr.new commit build.


📋 Code Quality: 💬 1 suggestion

No correctness defects. One optional note about matching on upstream error text.

Recommendation: 💬 Optional Nits

  • [SUGGESTION] The Vite config hint depends on the exact wording of an upstream BuildOutputError message (packages/cli/src/commands/build/index.ts:98)
View full review
  • packages/cli/src/commands/build/index.ts:93-107: the Vite config hint is added only when the error message starts with an exact upstream string. If that wording changes, the hint quietly stops appearing.
  • Checked and fine: assertProjectCommandsAvailable runs after the setupNeeded check in build and after prepareProject in dev. Configured projects are not blocked before their dependencies are installed.

✅ All other checks passed

🔒 Security: ✅ LGTM

Commands run as argv arrays with no shell, and group kills target only the child's own process group. The CLOUDFLARE_CF_AUTH marker is set after options.env, so callers cannot override it. Local .bin directories are prepended to the inherited PATH rather than replacing it.


📖 AGENTS.md: ✅ LGTM

No issues found.


⚡ Performance: ✅ LGTM

No performance concerns.


📝 Documentation: ✅ LGTM

The changeset, docs/architecture.md and packages/cli/AGENTS.md describe the native Vite and Vite+ command selection.


Reviewed commit: ae6403e4

Comment thread packages/cli/package.json Resolved
@petebacondarwin
petebacondarwin force-pushed the codex/native-vite-fallback branch from ae6403e to 9148e97 Compare November 14, 2026 08:30

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 790873d7.

This review, of 9148e972

💬 Approved with comments — Nothing changed since the last review introduces a defect. One optional suggestion remains about matching an upstream error message by its exact wording.

Findings: 1 suggestion

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


📋 Code Quality: 💬 1 suggestion

No new defects; one earlier optional suggestion remains.

Recommendation: 💬 Optional Nits

  • [SUGGESTION] Vite config hint depends on the exact wording of an upstream BuildOutputError message (packages/cli/src/commands/build/index.ts:98)
View full review
  • packages/cli/src/commands/build/index.ts:93-107: the hint to add cloudflare() to the Vite config only appears when the error message starts with an exact upstream string. If @cloudflare/build-output-utils changes that wording, the hint silently stops showing.

The overrides and tests added since the last review look correct. Shutdown handling (listener cleanup, escalation on a repeated signal, ignoring ESRCH, taskkill /T /F on Windows) holds up on inspection.


✅ All other checks passed

🚀 Release: ✅ LGTM

Risk: Medium. This change alters how project commands are selected and how subprocesses shut down. A minor changeset fits that change in behaviour. Tests cover build, dev, deploy, Preview and POSIX shutdown. As noted before, the autoconfig commit-build pin has to be replaced with the released version before cf is published.


🔒 Security: ✅ LGTM

Commands still run as argv arrays with no shell, and process-group kills only target the child's own group. Nothing changed since the last review alters the auth marker or the PATH handling.


📖 AGENTS.md: ✅ LGTM

No issues found.


⚡ Performance: ✅ LGTM

The child-process changes run once per command and do nothing that grows with load.


📝 Documentation: ✅ LGTM

The changeset, docs/architecture.md and packages/cli/AGENTS.md describe the native Vite and Vite+ command selection.


Reviewed commit: 9148e972

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 75c37538.

This review, of 4410e941

✅ Approved — No open findings. The stale fixture README version is fixed, and the author's check against autoconfig 0.13.0, which the code supports, answers the question about aliased Vite+ projects.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Overall risk: High. This release changes the public cf/config API and the Build Output format (v1), and raises the minimum versions of the Vite plugin (2.0.0-rc.0) and Wrangler (4.163.0). The two minor changesets describe the migrations and say to rebuild existing output before using --prebuilt. The pull request description sets the release order relative to the cf-vite removal upstream.


🔒 Security: ✅ LGTM

taskkill.exe is called through execFileSync with an argument array, not through a shell. On POSIX, kills go only to the child's own process group, and ESRCH is handled. The signal relay changes add no new input path, and credential isolation is unchanged.


📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

The dev and build paths check that the project's tools are available after setup. They also resolve executables through autoconfig's nodeModulesPaths. The Build Output v1 migration and the move to nested settings.accountId are applied the same way in deploy, Preview and triggers. For a project that only aliases vite to Vite+ core, assertProjectCommandsAvailable() refuses to run before anything is launched. A project that declares vite-plus gets vp dev and vp build.


⚡ Performance: ✅ LGTM

The new process handling runs only at shutdown: one process-group kill on POSIX, and one taskkill.exe call with a timeout on Windows. The force-kill timer is unref'd and cleared when SIGKILL is sent explicitly.


📝 Documentation: ✅ LGTM

fixtures/wrangler-bundler-project/README.md now says Wrangler 4.163.0 or newer, matching the delegate requirement.


Reviewed commit: 4410e941

@petebacondarwin
petebacondarwin force-pushed the codex/native-vite-fallback branch from 4410e94 to 75c3753 Compare November 16, 2026 12:54

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — No findings. The patches have not changed since the previous review, which was clean, and the migration and release notes cover the breaking changes.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Overall risk: High. This release changes the public cf/config API and moves Build Output to v1. It also raises the minimum versions of the Vite plugin (2.0.0-rc.0) and Wrangler (4.163.0). The two minor changesets describe the migrations and say to rebuild existing output before using --prebuilt. The pull request description gives the release order relative to the upstream cf-vite removal.


🔒 Security: ✅ LGTM

taskkill.exe is called with an argument array, not through a shell. On POSIX, kills go only to the child's own process group. Credential isolation is unchanged.


📖 AGENTS.md: ✅ LGTM

No issues found.


📋 Code Quality: ✅ LGTM

Dev and build check that the project's tools are available after prepareProject, so setup can still install them first. Both resolve executables through autoconfig's nodeModulesPaths.

The Build Output v1 migration and the nested settings.accountId are applied the same way in deploy, Preview and triggers. The Container default of 20 instances is kept.

Shutdown handling treats an explicit SIGKILL as overriding a pending graceful shutdown and clears the force-kill timer. It ignores ESRCH on POSIX and uses taskkill on Windows.


⚡ Performance: ✅ LGTM

The new process-tree cleanup runs only at shutdown: one process-group kill on POSIX, and one taskkill.exe call with a timeout on Windows.


📝 Documentation: ✅ LGTM

The fixture READMEs and the architecture notes match the new command routing and the minimum versions.


Reviewed commit: 75c37538

@ask-bonk

ask-bonk Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

No new concerns since the last review

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants