Repository navigation
feat: prepare cf 1.0 release candidate - #634
Open
petebacondarwin wants to merge 1 commit into
Open
petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
Contributor
|
LGTM |
2 of 5 tasks
commit: |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 287.1 ms | 3.7 ms | 283.6 ms | 295.0 ms |
| base | 287.7 ms | 3.5 ms | 281.9 ms | 293.9 ms |
Δ (PR vs base): — -0.7 ms (-0.2%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
Contributor
|
LGTM! |
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 12:42
5fdee96 to
ee7b1b2
Compare
Contributor
|
LGTM! |
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 12:47
ee7b1b2 to
b7494ff
Compare
1 task
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 12:54
b7494ff to
cdaafda
Compare
Contributor
|
LGTM |
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 13:13
cdaafda to
e589a42
Compare
Contributor
|
LGTM! |
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 13:26
e589a42 to
0013e62
Compare
Contributor
|
LGTM! |
petebacondarwin
force-pushed
the
codex/cf-release-candidate
branch
from
November 16, 2026 13:31
0013e62 to
d722b6c
Compare
Contributor
|
LGTM! |
There was a problem hiding this comment.
✅ Approved — The channel switch in .changeset/pre.json, the new changeset, Renovate following the Vite plugin's rc tag and the documentation updates are consistent with each other, and no defects were found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
.changeset/pre.json: Switching the tag frombetatorcis the normal way to change prerelease channels. The newcf-release-candidate.mdis not yet listed inchangesets, so the next versioning run will consume it.- Version number:
packages/cli/package.jsonis at1.0.0-beta.32, so the next version should continue the counter as1.0.0-rc.33, which matches the description. renovate.json5:followTag: "rc"for@cloudflare/vite-pluginmatches the2.0.0-rc.0that both Vite fixtures already pin. Miniflare stays onbeta, which this change does not touch.- Changeset:
cf-release-candidate.mduses"cf": minorwith an imperative title, as the repository's changeset rules require.
📝 Documentation: ✅ LGTM
The installation and publishing guidance in the changed files consistently names the rc channel.
Reviewed commit: d722b6ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move cf's 1.0 prereleases to the
rcchannel, update installation and publishing documentation, and have Renovate follow the Vite plugin's RC channel.Stack:
main→ #540 → this PR. Merged #622 provides the published Workers SDK dependencies, config RC migration, and Build Output v1 support. #540 owns native Vite/Vite+ command execution and shutdown handling. This PR contains only the release-channel configuration, its changeset, Renovate channel selection, and documentation.Merge #540, then retarget this PR to
main. Changesets will regenerate the existing Version Packages PR (#624) on thercchannel. The current planned version is1.0.0-rc.33, continuing the prerelease counter; confirm the generated version when that PR is updated.Validation:
pnpm check: all seven tasks passed on the restacked head.