Repository navigation
[vite-plugin] Update v1 to the November 10 runtime and API clients - #16801
edmundhung merged 3 commits into
Conversation
🦋 Changeset detectedLatest commit: f31208e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@GregBrimble (verified author of #16739 and #16740) and @petebacondarwin (latest qualifying pre-merge human ant-core approver for both originals, November 6 at 14:58:33Z and 15:01:15Z): please check this v1 dependency backport and approve it if it looks good. Retained remote-bindings uses the shared API fetch helpers for preview uploads, so custom API headers and diagnostic redaction have a concrete v1 effect. The same graph supplies the Artifacts X-Auth-Key forwarding fix and the matching Wrangler/auth/Container clients. #16757 already supplies the released November 9 runtime and earlier dependencies; they are not repeated here. For #16612, verified author @petebacondarwin: please check the local Browser Rendering dependency coverage and approve if it looks good. No qualifying human ant-core approval could be verified: cjol is outside the current team and workers-devprod is a bot, so no substitute reviewer is tagged. All three originals are covered by one coupled dependency graph above #16770 in native GitHub stack #16738. No public package source/tests/helpers are copied and private workspace references stay intact. This remains draft until pending Version Packages #16799 publishes: genuine lockfile generation currently fails for deploy-helpers 0.26.2. Formatting, changeset/pinning validators and diff checks pass; the released parent passes build, 58 checks, 262 plugin tests plus retained suites and fixtures. Those parent results do not validate the unpublished graph. |
|
@brady-eaiti (verified author of #16807) and @petebacondarwin (latest qualifying pre-merge human ant-core approver, November 9 21:06:38Z): please check this v1 backport and approve it if it looks good. The same Miniflare upgrade now supplies missing-assets placeholder cleanup on dispose; no upstream sources or dependency tests are copied. For #16810, recorded bot author For #16799, recorded bot author @workers-devprod and verified human ant-core approver @petebacondarwin (November 10 10:05:42Z): please check this v1 dependency backport and approve if it looks good. The actual release is Miniflare 5.20261110.0-beta with Wrangler 4.160.0; this existing PR retains the earliest coupled API-client upgrade, and now has a genuine npm lockfile. Build, all 58 checks and all 8 package test tasks pass, including 262 plugin tests. Earlier dependencies remain covered by #16757 and the Container lifecycle adaptation by #16770. Existing original-specific requests are not repeated. |
commit: |
|
Codeowners approval required for this PR:
|
There was a problem hiding this comment.
💬 Approved with comments — The dependency and Turbo environment updates look correct. The only note is a changelog gap: the missing-assets directory cleanup has no changeset.
Findings: 1 info (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🚀 Release: 💬 1 info
No changeset covers the missing-assets cleanup included in this runtime upgrade
Recommendation: 💬 Optional Nits
- [INFO] No changeset covers the missing-assets directory cleanup that this Miniflare upgrade brings in (from #16807) (
.changeset/v1-browser-artifacts-credentials.md:5)
View full review
The changesets cover the custom API headers and the Browser Rendering and Artifacts credential changes. None covers the missing-assets placeholder cleanup on dispose, which this Miniflare upgrade also brings in.
✅ All other checks passed
🔒 Security: ✅ LGTM
The new versions are exact pins and the private packages remain workspace:*. CLOUDFLARE_API_HEADERS is passed through Turbo the same way as the existing CLOUDFLARE_API_TOKEN.
📖 AGENTS.md: ✅ LGTM
No concerns.
📋 Code Quality: ✅ LGTM
The version bumps are consistent across the plugin and the packages it keeps.
⚡ Performance: ✅ LGTM
No performance concerns.
📝 Documentation: ✅ LGTM
No documentation concerns.
Reviewed commit: f31208e8
|
Checked the part I was tagged for. I don't have write access here, so please take this comment as my approval. |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Consume the published November 10 runtime and shared clients for v1 custom API headers, safe request diagnostics, local Browser Rendering, Artifacts authentication, and missing-assets directory cleanup. Retained remote-bindings invokes the shared API helpers for preview uploads, so
CLOUDFLARE_API_HEADERSalso passes through retained Turbo tasks.Updates the existing backport of #16739, #16740 and #16612 after Version Packages #16799 published. The actual release is Miniflare 5.20261110.0-beta, consistently pinned in the plugin and retained consumers; coupled Wrangler 4.160.0, workers-utils 0.53.0, workers-auth 0.18.0, deploy-helpers 0.26.2 and containers-shared 0.25.0 stay here. Workers types advance to 5.20261110.1. This also supplies #16807 and #16810 without separate backports. #16757 supplies the earlier November 9 graph; #16770 supplies the v1 Container lifecycle adaptation. Private workspace references remain intact.
The genuine pnpm lockfile is regenerated from npm; the publication blocker is resolved. Build, all 58 check tasks and all 8 package test tasks pass (262 plugin tests). All 6 retained fixture tasks also pass: 30 dev-registry tests, 5 harness tests and 2 browser tests. No credentialed E2E or full Vite/OS matrix was run.
Part of native GitHub stack #16738, above #16770. Merge the stack in order.
Note
This is a contribution from an AI agent: Codex.