Skip to content

[vite-plugin] Fix v1 Container Docker error guidance - #16818

Open
petebacondarwin wants to merge 3 commits into
vite-plugin-v1from
codex/vite-v1-backport-16682
Open

petebacondarwin wants to merge 3 commits into
vite-plugin-v1from
codex/vite-v1-backport-16682

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Backport the v1-relevant diagnostic fix from #16682. When Docker cannot be reached, v1 currently suggests --enable-containers=false, which the Vite plugin does not accept. Supply the caller-specific hint through the already-pinned containers-shared 0.25.0 API, retaining the valid dev.enable_containers setting and Wrangler config filename.

The remaining diff is one plugin option, a plugin API regression exercising the actual Docker failure, and a plugin patch changeset. Native cloudflare.config.ts Container export conversion and Vitest pool support are v2/other-consumer changes and are not transplanted. No dependency upgrade is needed: #16801 already supplies the optional hint API from #15695. No public dependency source or tests are copied.

Based on current vite-plugin-v1 after #16817 and the subsequent v1 releases merged. Synchronized the branch with the current target without changing the three-file diagnostic fix. This is the first remaining open PR in native GitHub stack #16900; #16859, #16860 and #16861 follow it. Merge the stack in order.

Validation: all 11 Container API tests pass, including the actual missing-Docker diagnostic. Build and all 58 workspace checks pass. The final full package suite passes all 8 tasks, including 266 plugin tests. The parent also passes all retained fixtures and affected Vite 6/7/8 build playground coverage. No credentialed E2E or full OS matrix was run.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixes existing error guidance without adding an API.

Note

This is a contribution from an AI agent: Codex.

@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 700574a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@ghostwriternr (verified author of #16682) and @jamesopstad (latest qualifying pre-merge human ant-core approver, November 5 11:28:09Z): please check this v1 adaptation and approve it if it looks good.

V1 still supports dev.enable_containers in Wrangler configuration, but it does not accept the suggested --enable-containers flag. This PR supplies the caller-specific diagnostic through the existing containers-shared 0.25.0 API instead of taking the unreleased 0.26.0 API break or native cloudflare.config.ts export conversion. #16801 already supplies the required dependency; #16817 supplies the separate build fix underneath. One plugin API regression exercises the actual missing-Docker error; all 11 Container tests, build and all 58 workspace checks pass. No public dependency sources or upstream dependency tests are copied. Added to native GitHub stack #16738; merge the stack in order.

@petebacondarwin
petebacondarwin marked this pull request as ready for review November 10, 2026 14:05
@workers-devprod
workers-devprod requested review from a team and cjol and removed request for a team November 10, 2026 14:06
@workers-devprod

workers-devprod commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@pkg-pr-new

pkg-pr-new Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16818

commit: 700574a

devin-ai-integration[bot]

This comment was marked as resolved.

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of a7f5f5fe.

This review, of 87661e0c

✅ Approved — This small, focused fix corrects the Docker error hint for v1. It comes with a regression test and a changeset, and no issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The caller-specific hint goes through the containers-shared API this branch already pins. The test exercises the real Docker failure path.


📝 Documentation: ✅ LGTM

The changeset describes the user-facing fix. No public documentation update is needed.


Reviewed commit: 87661e0c

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

Base automatically changed from codex/vite-v1-backport-16761 to vite-plugin-v1 November 11, 2026 14:54
@edmundhung
edmundhung force-pushed the codex/vite-v1-backport-16682 branch from 87661e0 to a7f5f5f Compare November 11, 2026 14:54

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 411f726b.

This review, of a7f5f5fe

✅ Approved — This small, focused fix corrects the Docker error hint for v1. It comes with a regression test and a changeset, and no issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The caller-specific hint goes through the containers-shared API this branch already pins. The test exercises the real Docker failure path.


📝 Documentation: ✅ LGTM

The changeset describes the user-facing fix. No public documentation update is needed.


Reviewed commit: a7f5f5fe — same changes as 87661e0c, so this is that commit's review (no new review was run; line numbers are as of 87661e0c)

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of 700574a3.

This review, of 411f726b

✅ Approved — This small, focused fix corrects the Docker error hint for v1. It comes with a regression test and a changeset, and no issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The caller-specific hint goes through the containers-shared API this branch already pins. The test exercises the real Docker failure path.


📝 Documentation: ✅ LGTM

The changeset describes the user-facing fix. No public documentation update is needed.


Reviewed commit: 411f726b — same changes as 87661e0c, so this is that commit's review (no new review was run; line numbers are as of 87661e0c)

…o Wrangler file

Inline-only Worker configs have no Wrangler file, so the hint now reuses the same file name as the rest of the Container guidance.

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — This small backport corrects the Docker error hint for v1, including inline-only configs. It comes with a regression test and a changeset, and I found no issues.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The configFileName value is now shared between the existing guidance and the new disableContainersHint, so inline-only configs name the Vite config file. The regression test runs the real prepareContainerImagesForDev with Docker missing and checks the wording of the hint.


📝 Documentation: ✅ LGTM

The plugin changeset describes the corrected error guidance. No public documentation change is needed.


Reviewed commit: 700574a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants