Repository navigation
[create-cloudflare] Quarantine experimental Waku E2E test - #16842
Conversation
@cloudflare/vite-plugin 1.69.0 fails `waku build` after static generation. Skip the experimental Waku test until a fixed v1 release is published.
|
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
There was a problem hiding this comment.
✅ Approved — Test-only change that quarantines one failing experimental E2E case. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code reviewer: ✅ LGTM
No issues found.
Reviewed commit: 8bd66576
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Quarantines the experimental Waku C3 E2E test, which has failed on the release PR since
@cloudflare/vite-plugin@1.69.0was published, e.g. https://github.com/cloudflare/workers-sdk/actions/runs/43073393667/job/130706903895.Waku starts a preview server with the same plugin instances during
waku build, and 1.69.0 now throwsExpected "assets-only" or "workers" plugin configwhen that happens. The plugin fix is tracked in #16841. Unquarantine once a fixed v1 release is published.