Skip to content

[create-cloudflare] Quarantine experimental Waku E2E test - #16842

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/c3-quarantine-experimental-waku
Nov 11, 2026
Merged

edmundhung merged 1 commit into
mainfrom
edmundhung/c3-quarantine-experimental-waku

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Quarantines the experimental Waku C3 E2E test, which has failed on the release PR since @cloudflare/vite-plugin@1.69.0 was published, e.g. https://github.com/cloudflare/workers-sdk/actions/runs/43073393667/job/130706903895.

Waku starts a preview server with the same plugin instances during waku build, and 1.69.0 now throws Expected "assets-only" or "workers" plugin config when that happens. The plugin fix is tracked in #16841. Unquarantine once a fixed v1 release is published.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this only skips a failing E2E case.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test-only change.

@cloudflare/vite-plugin 1.69.0 fails `waku build` after static
generation. Skip the experimental Waku test until a fixed v1 release
is published.
@changeset-bot

changeset-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8bd6657

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Nov 11, 2026
@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Nov 11, 2026
@ask-bonk

ask-bonk Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@16842

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@16842

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@16842

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@16842

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@16842

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@16842

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@16842

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@16842

miniflare

npm i https://pkg.pr.new/miniflare@16842

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@16842

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@16842

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@16842

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@16842

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@16842

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@16842

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@16842

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@16842

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@16842

wrangler

npm i https://pkg.pr.new/wrangler@16842

commit: 8bd6657

@edmundhung
edmundhung marked this pull request as ready for review November 11, 2026 23:38
@workers-devprod
workers-devprod requested review from a team and jamesopstad and removed request for a team November 11, 2026 23:38
@workers-devprod

workers-devprod commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — Test-only change that quarantines one failing experimental E2E case. No issues found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

No issues found.


Reviewed commit: 8bd66576

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Nov 11, 2026
@edmundhung
edmundhung merged commit 840ba05 into main Nov 11, 2026
99 of 100 checks passed
@edmundhung
edmundhung deleted the edmundhung/c3-quarantine-experimental-waku branch November 11, 2026 23:43
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants