Repository navigation
@cloudflare/build-output-utils v1 RC - #16917
Conversation
🦋 Changeset detectedLatest commit: 1c68442 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
fcd750a to
b8ae10f
Compare
There was a problem hiding this comment.
Superseded by the review of
1c68442a.
This review, of b8ae10f9
💬 Approved with comments — The fixes since the last review are correct and tested. The only note left is a SUGGESTION about the duplicated version-directory regex.
Findings: 1 suggestion
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 suggestion
The symlink mismatch in the guard is fixed. The version-directory pattern is still defined in two places.
Recommendation: 💬 Optional Nits
- [SUGGESTION]
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils/src/read.ts(packages/wrangler/src/deployment-bundle/cf-build-output-guard.ts:58)
View full review
- Fixed: symlinked
v<N>entry.findCloudflareBuildOutputnow acceptsentry.isDirectory() || entry.isSymbolicLink(), which matches the reader, and a test covers it. create-cloudflare/src/cf/deploy.ts: checks v1 before v0. The error message still names the v1 path when neither exists, and the tests cover all three cases.- Still open:
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils.
✅ All other checks passed
🚀 Release: ✅ LGTM
Risk: Low. The changesets cover the affected packages.
🔒 Security: ✅ LGTM
The C3 config paths are fixed constants joined to the project path. Counting a symlinked v<N> entry makes the guard stricter, and the reader still rejects symlinks inside the selected version directory.
📖 AGENTS.md: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: b8ae10f9
b8ae10f to
1c68442
Compare
There was a problem hiding this comment.
Superseded by the review of
a89025f6.
This review, of 1c68442a
💬 Approved with comments — The fixes since the last review are correct and tested. The only note left is a SUGGESTION about the duplicated version-directory regex.
Findings: 1 suggestion
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 suggestion
The symlink mismatch in the guard is fixed. The version-directory pattern is still defined in two places.
Recommendation: 💬 Optional Nits
- [SUGGESTION]
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils/src/read.ts(packages/wrangler/src/deployment-bundle/cf-build-output-guard.ts:58)
View full review
- Fixed: symlinked
v<N>entry.findCloudflareBuildOutputnow acceptsentry.isDirectory() || entry.isSymbolicLink(), which matches the reader, and a test covers it. create-cloudflare/src/cf/deploy.ts: checks v1 before v0. The error message still names the v1 path when neither exists, and the tests cover all three cases.- Still open:
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils.
✅ All other checks passed
🚀 Release: ✅ LGTM
Risk: Low. The changesets cover the affected packages.
🔒 Security: ✅ LGTM
The C3 config paths are fixed constants joined to the project path. Counting a symlinked v<N> entry makes the guard stricter, and the reader still rejects symlinks inside the selected version directory.
📖 AGENTS.md: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: 1c68442a — same changes as b8ae10f9, so this is that commit's review (no new review was run; line numbers are as of b8ae10f9)
|
#16922 needs to be merged for the tests in this PR to pass. |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
1c68442 to
a89025f
Compare
There was a problem hiding this comment.
💬 Approved with comments — The fixes since the last review are correct and tested. The only note left is a SUGGESTION about the duplicated version-directory regex.
Findings: 1 suggestion
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
📋 Code Quality: 💬 1 suggestion
The symlink mismatch in the guard is fixed. The version-directory pattern is still defined in two places.
Recommendation: 💬 Optional Nits
- [SUGGESTION]
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils/src/read.ts(packages/wrangler/src/deployment-bundle/cf-build-output-guard.ts:58)
View full review
- Fixed: symlinked
v<N>entry.findCloudflareBuildOutputnow acceptsentry.isDirectory() || entry.isSymbolicLink(), which matches the reader, and a test covers it. create-cloudflare/src/cf/deploy.ts: checks v1 before v0. The error message still names the v1 path when neither exists, and the tests cover all three cases.- Still open:
VERSION_DIRECTORY_PATTERNis defined in both Wrangler andbuild-output-utils.
✅ All other checks passed
🚀 Release: ✅ LGTM
Risk: Low. The changesets cover the affected packages.
🔒 Security: ✅ LGTM
The C3 config paths are fixed constants joined to the project path. Counting a symlinked v<N> entry makes the guard stricter, and the reader still rejects symlinks inside the selected version directory.
📖 AGENTS.md: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: a89025f6 — same changes as b8ae10f9, so this is that commit's review (no new review was run; line numbers are as of b8ae10f9)
Release the first
1.0.0release candidate, which reads and writes Build Output v1Build Output now lives in
.cloudflare/output/v1/. Only the.cloudflare/output/v<N>/naming convention is permanent: a future breaking change to the format would use a new version directory.readBuildOutput()lists the version directories first and throws aBuildOutputErrorunless it finds exactly onev1directory. This means output written by an older or newer tool, or a stalev0tree left next to a fresh one, fails with a clear error instead of being misread or deployed.BuildOutputErrornow has acode(not-found,newer-version,older-version,multiple-versions,unknown-fieldsorinvalid) plusfoundVersions,supportedVersions,producerandunknownFields. Consumers can use these to show their own advice instead of parsing the message. When a config contains fields the reader doesn't support, the error lists each field and names the tool that wrote the output.The root
config.jsonnow nests account settings undersettings, which is left out when none are set, and can record the tool that wrote the output in an optionalproducerfield.writeRootConfig()takes an options object, matching the otherwrite*functions:A picture of a cute animal (not mandatory, but encouraged)